Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Flanker to improve parsing of badly encoded mail #46

Closed
kdeldycke opened this issue Dec 30, 2016 · 3 comments
Closed

Use Flanker to improve parsing of badly encoded mail #46

kdeldycke opened this issue Dec 30, 2016 · 3 comments
Labels
✨ enhancement Improvement or change to an existing feature

Comments

@kdeldycke
Copy link
Owner

kdeldycke commented Dec 30, 2016

Detection and skipping of badly encoded mails has been added in #47. We can go further and improve parsing of these mails.

Flanker is a good effort to better parse email content in Python: https://github.com/mailgun/flanker . The idea would be to reuse its parsing utilities.

Unfortunately, Flanker doesn't target Python 3: mailgun/flanker#106 . Some efforts are made on side branches and forks to make Flanker Python 3 ready: mailgun/flanker#106 (comment) . But reconciliation of these forks is unlikely to happen. 😢

@kdeldycke
Copy link
Owner Author

Digging deeper in Flanker's code, it seems that the later rely on the chardet module to magically guess badly encoded mails. This is strangely familiar with @kdmurray91 approach from #36.

So if we can't go the Flanker route, maybe we can reuse #36 code to enhance mail parsing.

@kdeldycke kdeldycke changed the title Reuse flanker's mail parsing utilities Improve mail parsing with flanker Jan 13, 2017
@kdeldycke kdeldycke changed the title Improve mail parsing with flanker Improve parsing of badly encoded mail with flanker Jan 13, 2017
@kdeldycke kdeldycke changed the title Improve parsing of badly encoded mail with flanker Improve parsing of badly encoded mail with Flanker Jan 13, 2017
@kdeldycke kdeldycke changed the title Improve parsing of badly encoded mail with Flanker Improve parsing of badly encoded mail Jun 7, 2017
@kdeldycke
Copy link
Owner Author

Flanker is now Python3-compatible. But we will close this issue for now while we wait for community feedbacks following the revival of this project.

@kdeldycke kdeldycke changed the title Improve parsing of badly encoded mail Use Flanker to improve parsing of badly encoded mail Sep 8, 2020
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2020
@kdeldycke kdeldycke added ✨ enhancement Improvement or change to an existing feature and removed enhancement labels Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✨ enhancement Improvement or change to an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant