From 40926158e52d9395d069e9ed89f06418559a5430 Mon Sep 17 00:00:00 2001 From: Gabi Davar Date: Sun, 26 Jan 2025 15:26:56 +0200 Subject: [PATCH] feat: support disabling docker legacy service links creation in keda containers (#725) * Disable docker legacy service links Signed-off-by: Gabi Davar * switch default to true Signed-off-by: Gabi Davar --------- Signed-off-by: Gabi Davar --- keda/templates/manager/deployment.yaml | 1 + keda/templates/metrics-server/deployment.yaml | 1 + keda/templates/webhooks/deployment.yaml | 1 + keda/values.yaml | 4 ++++ 4 files changed, 7 insertions(+) diff --git a/keda/templates/manager/deployment.yaml b/keda/templates/manager/deployment.yaml index 3c9d9050..33de49dd 100644 --- a/keda/templates/manager/deployment.yaml +++ b/keda/templates/manager/deployment.yaml @@ -45,6 +45,7 @@ spec: {{- end }} {{- end }} spec: + enableServiceLinks: {{ .Values.enableServiceLinks }} {{- if .Values.priorityClassName }} priorityClassName: {{ .Values.priorityClassName | quote }} {{- end }} diff --git a/keda/templates/metrics-server/deployment.yaml b/keda/templates/metrics-server/deployment.yaml index 23a4ecd0..349b9d89 100644 --- a/keda/templates/metrics-server/deployment.yaml +++ b/keda/templates/metrics-server/deployment.yaml @@ -44,6 +44,7 @@ spec: {{- end }} {{- end }} spec: + enableServiceLinks: {{ .Values.enableServiceLinks }} {{- if .Values.priorityClassName }} priorityClassName: {{ .Values.priorityClassName | quote }} {{- end }} diff --git a/keda/templates/webhooks/deployment.yaml b/keda/templates/webhooks/deployment.yaml index b5b5e0f6..68de88e7 100644 --- a/keda/templates/webhooks/deployment.yaml +++ b/keda/templates/webhooks/deployment.yaml @@ -43,6 +43,7 @@ spec: {{- end }} {{- end }} spec: + enableServiceLinks: {{ .Values.enableServiceLinks }} {{- if .Values.priorityClassName }} priorityClassName: {{ .Values.priorityClassName | quote }} {{- end }} diff --git a/keda/values.yaml b/keda/values.yaml index 8661a4e4..e429fe09 100644 --- a/keda/values.yaml +++ b/keda/values.yaml @@ -863,3 +863,7 @@ asciiArt: true # -- When specified, each rendered resource will have `app.kubernetes.io/managed-by: ${this}` label on it. Useful, when using only helm template with some other solution. customManagedBy: "" + +# -- Enable service links in pods. Although enabled, mirroring k8s default, it is highly recommended to disable, +# due to its legacy status [Legacy container links](https://docs.docker.com/engine/network/links/) +enableServiceLinks: true