Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance profiling on kedro new with starter and without starter #120

Closed
astrojuanlu opened this issue Feb 20, 2023 · 5 comments
Closed

Comments

@astrojuanlu
Copy link
Member

astrojuanlu commented Feb 20, 2023

When the telemetry is enabled and the Internet connection is choppy or poor, kedro new takes a lot to run.

It could be because of the telemetry timeout:

url=HEAP_ENDPOINT, headers=HEAP_HEADERS, data=json.dumps(data), timeout=10

Or it could be because of cloning the starter itself. This is related to kedro-org/kedro#1476

@astrojuanlu
Copy link
Member Author

Example from yours truly:

% /usr/bin/time -p kedro new --starter=standalone-datacatalog --config=kedro.yaml

The project name 'kedro-polars' has been applied to: 
- The project title in /Users/juan_cano/Projects/QuantumBlack Labs/talk-kedro-polars/kedro-polars/README.md 
- The folder created for your project in /Users/juan_cano/Projects/QuantumBlack Labs/talk-kedro-polars/kedro-polars 
- The project's python package in /Users/juan_cano/Projects/QuantumBlack Labs/talk-kedro-polars/kedro-polars/src/kedro_polars

A best-practice setup includes initialising git and creating a virtual environment before running 'pip install -r src/requirements.txt' to install project-specific dependencies. Refer to the Kedro documentation: https://kedro.readthedocs.io/

Change directory to the project generated in /Users/juan_cano/Projects/QuantumBlack Labs/talk-kedro-polars/kedro-polars by entering 'cd /Users/juan_cano/Projects/QuantumBlack Labs/talk-kedro-polars/kedro-polars'
real 24.91
user 1.43
sys 1.03

(almost 25 seconds for a kedro new)

@merelcht merelcht changed the title Reduce default telemetry timeout Performance profiling on kedro new with starter and without starter Mar 13, 2023
@ankatiyar
Copy link
Contributor

Suggestion: Making kedro-telemetry use after_command_run hook instead of before_command_run might solve this problem!

@astrojuanlu
Copy link
Member Author

Thanks @ankatiyar! I think when I opened this issue I had the impression that this was because of telemetry, but actually it could be cloning the starter. I'm renaming this to clarify.

@astrojuanlu astrojuanlu changed the title Performance profiling on kedro new with starter and without starter Performance profiling on kedro new with starter and without starter Oct 5, 2023
@astrojuanlu
Copy link
Member Author

Actually, maybe we should close it in favour of kedro-org/kedro#1476

@merelcht
Copy link
Member

Closing in favour of kedro-org/kedro#1476

@merelcht merelcht closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants