-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kedro-Airflow
configuration
#229
Comments
I have a few questions @sbrugman
This is same as 2, I think 1 is the more important question here, whether how we pass or parse the argument is trivial. |
Am I understanding your question correctly that if the user add an additional parameter, can we make it in a way that the template does not have to be updated? The The arguments that already in the template file, would be configured dynamically. The list itself and its defaults will stay the same. Changing the values is up to the user. There is small a difference in functionality between reading from the Kedro config (e.g. |
@sbrugman in that case I think this is a good improvement. Regard to config, it should be quite easy to do, using the after_contrxt_created hook you can use kedro config. The CLI argument should override config value if provided. |
Closed by #233 |
Description
When using the kedro to Airflow dags conversion, configuration differs per DAG, there is currently no out-of-the-box way to automatically provide parameters such as the
schedule_interval
,owner
per pipeline. This is useful when the dags are generated and deployed in a devops pipeline without manual intervention.Happy to contribute this feature once there is consensus on an implementation.
Possible Implementation
Preferably, configuration such as
conf/base/airflow.yml
orconf/base/airflow/[PIPELINE].yml
is passed on to the template rendering as kwargs. The benefit is that the configuration is in one place, and it's consistent within the Kedro framework.Is any of the other CLI
kedro [command]
having access to the kedro config?Another implementation is to allow argument to
kedro airflow create
that supports passing parameters (e.g.--param key=value
). The user then has to take responsibility of passing the parameters.Possible Alternatives
Alternatively, the user generates templates for each pipeline. This requires no modification of the plugin, but puts a lot of burden on the user.
The text was updated successfully, but these errors were encountered: