Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kedro-airflow: Grouping in memory is not working properly #655

Closed
ankatiyar opened this issue Apr 16, 2024 · 1 comment · Fixed by #664
Closed

kedro-airflow: Grouping in memory is not working properly #655

ankatiyar opened this issue Apr 16, 2024 · 1 comment · Fixed by #664
Assignees
Labels
airflow bug Something isn't working

Comments

@ankatiyar
Copy link
Contributor

Description

The --group-in-memory flag is a new addition #241 and hasn't been released yet.

Running kedro airflow create --group-in-memory and kedro airflow create with the spaceflights project creates the exact same DAGs - there's some issue in the determining whether a dataset is MemoryDataset

dataset = catalog._datasets.get(dataset_name, None)
return dataset is not None and isinstance(dataset, MemoryDataset)

^ returns None for datasets that are not in the catalog (dataset factory datasets or MemoryDatasets

There might also be some problems with dataset factories - still investigating

@ankatiyar ankatiyar added the bug Something isn't working label Apr 16, 2024
@astrojuanlu
Copy link
Member

cc @sbrugman FYI!

@ankatiyar ankatiyar self-assigned this Apr 17, 2024
@ankatiyar ankatiyar moved this to To Do in Kedro Framework Apr 17, 2024
@ankatiyar ankatiyar moved this from To Do to In Progress in Kedro Framework Apr 17, 2024
@ElenaKhaustova ElenaKhaustova moved this from In Progress to In Review in Kedro Framework May 7, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro Framework May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airflow bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants