Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): Updated Dependency Manager for kedro-docker to uv #929

Merged

Conversation

MinuraPunchihewa
Copy link
Contributor

@MinuraPunchihewa MinuraPunchihewa commented Nov 9, 2024

Description

This PR updates the dependency management for kedro-docker to be handled via uv.

Fixes #906

Development notes

Both template Dockerfiles have been updated to use uv for dependency management. The changes have been tested by building a container for an existing Docker project (starter). See the screenshot below:

image

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes
  • Received approvals from at least half of the TSC (required for adding a new, non-experimental dataset)

@MinuraPunchihewa MinuraPunchihewa marked this pull request as ready for review November 9, 2024 12:49
@MinuraPunchihewa
Copy link
Contributor Author

Hey @astrojuanlu and @merelcht,
This is my PR for switching to uv for dependency management in kedro-docker.

@merelcht merelcht self-requested a review November 11, 2024 10:32
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MinuraPunchihewa , LGTM! 👍

Can you add this to the release notes including your name as contributor?

Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @MinuraPunchihewa :)

Signed-off-by: Minura Punchihewa <[email protected]>
@MinuraPunchihewa
Copy link
Contributor Author

Thanks, guys.
@merelcht I've just updated the release notes.

@merelcht merelcht merged commit 78bc252 into kedro-org:main Nov 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to uv in kedro-docker
3 participants