Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a callback as prop to React component to track node click in flowchart #2022

Closed
1 task
Tracked by #58 ...
jitu5 opened this issue Aug 2, 2024 · 0 comments · Fixed by #2027
Closed
1 task
Tracked by #58 ...

Introduce a callback as prop to React component to track node click in flowchart #2022

jitu5 opened this issue Aug 2, 2024 · 0 comments · Fixed by #2027
Assignees
Labels
Issue: Feature Request Javascript Pull requests that update Javascript code

Comments

@jitu5
Copy link
Contributor

jitu5 commented Aug 2, 2024

Description

Add a callback function as a prop to the Kedro-Viz React component. This callback will track node clicks, enabling developers to handle node click events outside of the component. This enhancement aims to provide more flexibility and control over interactions within the flowchart and facilitates communication with the Kedro extension to understand which node the user clicked and pass on the node data to the Kedro extension.

Context

This feature will allow users of the Kedro-Viz component to define custom behavior when nodes are clicked. It will be particularly useful for applications that require interactions such as displaying detailed information about a node. Additionally, it enhances communication with the Kedro extension by providing node click data.

Possible Implementation

  • Add the onNodeClick prop to the Kedro-Viz component's prop types.
  • Update the node click handler within the component to call onNodeClick with appropriate node data.
  • Implement the logic to pass node data to the Kedro extension.

This issue is linked to parent ticket #1968

Checklist

  • Include labels so that we can categorise your feature request
@jitu5 jitu5 added this to Kedro-Viz Aug 2, 2024
@jitu5 jitu5 moved this to Backlog in Kedro-Viz Aug 2, 2024
@jitu5 jitu5 added the Javascript Pull requests that update Javascript code label Aug 2, 2024
@rashidakanchwala rashidakanchwala moved this from Backlog to Todo in Kedro-Viz Aug 5, 2024
@jitu5 jitu5 moved this from Todo to In Progress in Kedro-Viz Aug 6, 2024
@jitu5 jitu5 self-assigned this Aug 6, 2024
@jitu5 jitu5 moved this from In Progress to In Review in Kedro-Viz Aug 6, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro-Viz Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Feature Request Javascript Pull requests that update Javascript code
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant