Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NodeList Component #2037

Closed
4 of 5 tasks
rashidakanchwala opened this issue Aug 14, 2024 · 1 comment
Closed
4 of 5 tasks

Refactor NodeList Component #2037

rashidakanchwala opened this issue Aug 14, 2024 · 1 comment
Assignees

Comments

@rashidakanchwala
Copy link
Contributor

rashidakanchwala commented Aug 14, 2024

Description

Our Nodelist component is too confusing. We have a lot of nested components, and most of the time we pass props from parent to child but sometimes we also connect the child to redux state and get props directly from the state. This ticket is to rethink this component properly and refactor it.

Context

Why is this change important to you? How would you use it? How can it benefit other users?

Possible Implementation

(Optional) Suggest an idea for implementing the addition or change.

Possible Alternatives

(Optional) Describe any alternative solutions or features you've considered.

Checklist

  • Include labels so that we can categorise your feature request
@Huongg
Copy link
Contributor

Huongg commented Oct 25, 2024

As per our team discussions, the refactoring will be executed in multiple phases:

Miro board for the plan: https://miro.com/app/board/uXjVLTeWe88=/

Screenshot 2024-10-25 at 12 58 57
  • Phase 1: Refactor the node-list-row component. PR-2143
  • Phase 2: Separate and refactor the node-list-groups (also known as filter groups) from the node-list component. Issue-2153
  • Phase 3: Refactor the node-list-tree component issue-2154
  • Phase 4: Refactor the parent component and the state management of the node-list. issue-2155

@rashidakanchwala rashidakanchwala moved this from In Review to Backlog in Kedro-Viz Oct 28, 2024
@rashidakanchwala rashidakanchwala moved this from Backlog to In Progress in Kedro-Viz Nov 11, 2024
@rashidakanchwala rashidakanchwala moved this from In Progress to In Review in Kedro-Viz Nov 11, 2024
@Huongg Huongg closed this as completed Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants