Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kedro-viz lite banner icon #2128

Open
stephkaiser opened this issue Oct 7, 2024 · 5 comments · May be fixed by #2196
Open

Update kedro-viz lite banner icon #2128

stephkaiser opened this issue Oct 7, 2024 · 5 comments · May be fixed by #2196

Comments

@stephkaiser
Copy link

stephkaiser commented Oct 7, 2024

Description

We've gotten feedback that the user warning banner for kedro-viz lite is too aggressive and gives the impression that something is broken or there is an issue.

Possible Implementation

A quick fix to this would be to change the icon on the banner from a X to a warning icon instead.

Related - #2058

Image

@datajoely
Copy link
Contributor

Or maybe ℹ️ not ⚠️ ?

@stephkaiser stephkaiser moved this from Backlog to Todo in Kedro-Viz Nov 7, 2024
@stephkaiser
Copy link
Author

@datajoely
Copy link
Contributor

This is definitely an improvement, but I think this still sends the wrong message.

Missing dependencies - For the best experience with full functionality, please install the missing Kedro project dependencies.

I would argue:

  • The banner should still be less prominent, more information than warning.
  • If the user has intentionally run in --lite mode (which we're already seeing user value for - great job team) I think they don't need to be told they're not getting the "best" expereince. It's an intentional action.

With the above in mind I'd like to pitch:

"ℹ️ Features such as dataset previews are disabled in --lite mode as Python dependencies are not required [Learn More]`

  • The user is being informed of the limitations of their chosen approach
  • There is not suggestion what they're doing is wrong, just differen
  • It's slightly less mysterious about what constitutes the full experience

@ravi-kumar-pilla
Copy link
Contributor

Hi @datajoely , Thank you for the suggestions. I agree with the informative approach. I have few issues with the text though:

  1. Regarding the term Python dependencies in the message is a bit confusing to me.
  2. The feature dataset preview is not entirely disabled in lite mode. Example if someone installed csv dataset, they can preview csv dataset but cannot preview an excel or other datasets whose dependencies are missing. Lite mode only mocks dependencies that are missing.

Something along the below lines would be fine -

"ℹ️ Some features might be disabled in --lite mode due to missing dependencies. [Learn More]`

-> User can click on Learn More to find out the limitations, but we show an informative generic text. What do you think ?

Thank you

@datajoely
Copy link
Contributor

I think your suggestions are great, @ravi-kumar-pilla - I'd also push for the banner to be less aggressive still, possibly more transparent :)

@Huongg Huongg linked a pull request Nov 19, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

4 participants