You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't think we want to necessarily pull things like qtconsole or even ipywidgets.
This is related to #2519 in the sense that these should not be project dependencies anyway, but even when we address gh-2519, we should make these dependencies slimmer (see also (see #2569 (comment) for extra discussion). At the same time, our kedro.ipython extension isn't doing anything fancy, so apart from incompatibilities with other packages, we should keep upper version caps to a minimum I'd say.
Context
I'm happy to report that %load_ext kedro.ipython works nicely in Jupyter (Classic) Notebook 7.0.0rc0 🎉
And it would be cool if our users could benefit from the new interface as soon as it's out.
Note that Notebook is now based on JupyterLab, so it has more dependencies.
Anecdotally, I've found that many users still stick to the classic notebook interface and not all of them have migrated, nor intend to, to JupyterLab.
Possible Implementation
Make our pinnings something like
# requirements.txt
ipython>=8.10 # runtime dependency of kedro.ipython
notebook>=7.0 # favor modern version for better usability
# jupyterlab # it's a dependency of notebook already, so not even needed
Alternatively, we could drop the classic notebook and have users install only JupyterLab:
# requirements.txt
ipython>=8.10 # runtime dependency of kedro.ipython
jupyterlab>=3.0 # whatever version, old or new
# notebook # not included, fewer dependencies are installed
The text was updated successfully, but these errors were encountered:
Would this PR include evaluation of Jupiter Lab 4.x? I don't think anything should break, but it's probably worth checking in relaxing it. Noting, as discussed in backlog grooming, so it's not forgotten.
Description
We're pinning Jupyter in various ways in the development requirements for projects:
kedro/kedro/templates/project/{{ cookiecutter.repo_name }}/src/requirements.txt
Lines 4 to 8 in c48a846
and we're pulling more dependencies than needed. For example,
jupyter
in itself is basically a metapackage:https://pypi.org/project/jupyter/1.0.0/#files
and it ships a bunch of stuff:
I don't think we want to necessarily pull things like
qtconsole
or evenipywidgets
.This is related to #2519 in the sense that these should not be project dependencies anyway, but even when we address gh-2519, we should make these dependencies slimmer (see also (see #2569 (comment) for extra discussion). At the same time, our
kedro.ipython
extension isn't doing anything fancy, so apart from incompatibilities with other packages, we should keep upper version caps to a minimum I'd say.Context
I'm happy to report that
%load_ext kedro.ipython
works nicely in Jupyter (Classic) Notebook 7.0.0rc0 🎉And it would be cool if our users could benefit from the new interface as soon as it's out.
Note that Notebook is now based on JupyterLab, so it has more dependencies.
Anecdotally, I've found that many users still stick to the classic notebook interface and not all of them have migrated, nor intend to, to JupyterLab.
Possible Implementation
Make our pinnings something like
This would be blocked on gh-2158.
Possible Alternatives
Alternatively, we could drop the classic notebook and have users install only JupyterLab:
The text was updated successfully, but these errors were encountered: