Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Investigate electrum server stability #113

Open
nkuba opened this issue Oct 3, 2019 · 2 comments
Open

Investigate electrum server stability #113

nkuba opened this issue Oct 3, 2019 · 2 comments
Milestone

Comments

@nkuba
Copy link
Member

nkuba commented Oct 3, 2019

It happens that CI tests are failing, e.g. https://circleci.com/gh/keep-network/tbtc-dapp/878

  1) BitcoinSPV
       getTransactionProof:
     Error: failed to get merkle proof: [Error: failed to get transaction merkle: [tx 72e7fd57c2adb1ed2305c4247486ff79aec363296f02ec65be141904f80d214e not in block at height 1,569,341]]
      at merkleProof.client.getMerkleProof.catch (src/BitcoinSPV.js:57:15)
      at processTicksAndRejections (internal/process/task_queues.js:86:5)

It may be caused by the unreliability of public testnet electrum servers. As part of this task, we need to investigate the problem and find a solution.

Possible solutions:

  1. Use stable public mainnet electrum server; update test data to reflect mainnet.
  2. Use our internal testnet electrum server; access it from CircleCI.
  3. Mock electrum server responses for unit tests; prepare separate integration test suite to test real electrum server.
@nkuba nkuba added dev 🐛 bug Something isn't working and removed 🐛 bug Something isn't working labels Oct 3, 2019
@nkuba
Copy link
Member Author

nkuba commented Oct 15, 2019

It happened also with our internal electrum server in the dapp (not in CI):

Error: failed to get bitcoin spv proof: 
Error: failed to get merkle proof: 
[Error: failed to get transaction merkle: 
[tx f1ee49a165835bfcb7860d056a5d891089218b128eaf3dcca32c6b0b06d3b2b6 not in block at height 1,583,023]]

@nkuba nkuba added this to the v0.2.0 milestone Oct 15, 2019
@nkuba nkuba changed the title Investigate CI tests stability / electrum server Investigate electrum server stability Oct 15, 2019
@Shadowfiend
Copy link
Contributor

Strongly in favor of option (3), fwiw.

@mhluongo mhluongo removed dev labels Aug 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants