Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Improve UI/UX by preventing or warning users when there are insufficient signer bonds to cover deposit refunds #259

Open
culgin opened this issue Jul 14, 2020 · 2 comments
Labels
🆕 enhancement New feature or request 👩‍⚕️triage Needs further attention and categorization

Comments

@culgin
Copy link

culgin commented Jul 14, 2020

Description:

The UI should warn or prevent users from initiating a deposit when there are is sufficient signers.

As shown in the transaction below, gas fees were incurred when a deposit is initiated but subsequently rejected by the smart contract.
https://ropsten.etherscan.io/tx/0xc6af32241decdc2e6a71a21fd47e6bce0b0d4db312829fcb1aa4ff3317ce1da5

A better UX will be to prevent this from happening or at least show a prominent warning that this transaction is bound to fail.

Steps to reproduce the behavior:

  1. Go to tBTC minting dapp
  2. Initiate a tBTC minting request
  3. On step 2, "Initiating Deposit". An error is shown on Metamask but not on the page UI. Users may just proceed with the transaction and rejected at the smart contract.

Screenshots:

image

image

image

@culgin culgin added the 🆕 enhancement New feature or request label Jul 14, 2020
@Shadowfiend Shadowfiend changed the title Improve UI/UX by preventing or warning users when there are insufficient signers to initiate a deposit Improve UI/UX by preventing or warning users when there are insufficient signer bonds to cover deposit refunds Jul 14, 2020
@Shadowfiend
Copy link
Contributor

Shadowfiend commented Jul 14, 2020

This is actually different than having insufficient signers. In the rare case that signers fail to properly form the signing group, the depositor (i.e., you) can claim a refund of the payment made to open the deposit. This revert happens when the bond the deposit requires from the signers is not enough to cover that refund. Rather than allow you to open a deposit you might not get refunded for, we quit early.

I adjusted the title accordingly; the core point of having a clearer error earlier sooner in the flow is still absolutely valid.

@culgin
Copy link
Author

culgin commented Jul 15, 2020

This is actually different than having insufficient signers. In the rare case that signers fail to properly form the signing group, the depositor (i.e., you) can claim a refund of the payment made to open the deposit. This revert happens when the bond the deposit requires from the signers is not enough to cover that refund. Rather than allow you to open a deposit you might not get refunded for, we quit early.

I adjusted the title accordingly; the core point of having a clearer earlier sooner in the flow is still absolutely valid.

Thanks for the clarfication!

@mhluongo mhluongo added the 👩‍⚕️triage Needs further attention and categorization label Jul 20, 2020
@Shadowfiend Shadowfiend removed the 👩‍⚕️triage Needs further attention and categorization label Jul 24, 2020
@Gluzman Gluzman added the 👩‍⚕️triage Needs further attention and categorization label Aug 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🆕 enhancement New feature or request 👩‍⚕️triage Needs further attention and categorization
Projects
None yet
Development

No branches or pull requests

4 participants