Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display maximum redemption amount in BTC when wallet have not enough funds #759

Closed
michalinacienciala opened this issue Dec 13, 2023 · 1 comment · Fixed by #817
Closed

Comments

@michalinacienciala
Copy link
Contributor

When user requests unminting but there's not enough funds in the wallets to process that request, we show error like this:
image

Could we display the amount in BTC, not satoshi? Or show satoshi but with BTC equivalent in brackets? User may want to request the max possible redemption after seeing the error, so it would be easier for them to already have the amount in the format that needs to be provided on the unmint form.

From @michalsmiarowski :

This is an error thrown straight in tbtc-v2.ts sdk:

if (!walletData)
throw new Error(
`Could not find a wallet with enough funds. Maximum redemption amount is ${maxAmount} Satoshi.`
)

I'm not sure if we can change it on the front-end, because we might not receive the satoshi amount there 🤔 so we would have to probably change it in the lib if it's necessary

@ptdatta
Copy link
Contributor

ptdatta commented Jun 24, 2024

Hey @michalinacienciala please review this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants