Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release solidity/v1.5.2 #769

Closed
13 tasks done
lukasz-zimnoch opened this issue Jan 15, 2024 · 0 comments
Closed
13 tasks done

Release solidity/v1.5.2 #769

lukasz-zimnoch opened this issue Jan 15, 2024 · 0 comments
Assignees
@lukasz-zimnoch
Labels
⛓️ solidity Solidity contracts
Milestone
solidity/v1.5.2

Comments

@lukasz-zimnoch
Copy link
Member

lukasz-zimnoch commented Jan 15, 2024 •
edited
Loading

Team Address
Threshold Council 0x9f6e831c8f8939dc0c830c6e492e7cef4f9c2f5f
tBTC Deployer 0x123694886DBf5Ac94DDA07135349534536D14cAf

Rationale

Release solidity/v1.5.2 is a patch introducing changes developed as part of GHSA-wg2x-rv86-mmpx. Release solidity/v1.5.2 is branched off from the currently deployed solidity/v1.5.1 version. Version solidity/v1.5.2 could not be branched off directly from main because main contains some features that are not ready for release yet (e.g. removed WalletCoordinator, added deposits with extra data). Those features will be released as solidity/v1.6.0 when the time comes.

Checklist

Steps executed by tBTC Deployer:

  • Deploy and verify a new instance of the DepositSweep library (new instance deployed at 0x53f26BfE896CC4267720cDAf64E9A0c8Fa8f13c2)
  • Deploy and verify a new instance of the MovingFunds library (new instance deployed at 0x3106675EDE4A64d70131247466FD8704A3d42123)
  • Deploy and verify a new instance of the Redemption library (new instance deployed at 0x7D807e9CE1ef73048FEe9A4214e75e894ea25914)
  • Deploy and verify a new Bridge contract implementation (must use new instances of the above libraries) (new implementation deployed at 0x3A4a6919F70e5b0aA32401747C471eCfe2322C1b)
  • Deploy and verify a new instance of the MaintainerProxy contract (new instance deployed at 0x535E01F948458E0b64F9dB2A01Da6F32E240140f)
  • Transfer ownership of the new MaintainerProxy to the Threshold Council
  • Deploy the new version of the SPV maintainer bot

Steps executed by Threshold Council:

  • Point the Bridge proxy to the new implementation (ProxyAdmin address is 0x16A76d3cd3C1e3CE843C6680d6B37E9116b5C706, Bridge proxy address is 0x5e4861a80B55f035D899f66772117F00FA0E8e7B)
  • Authorize the new MaintainerProxy in the Bridge
  • Authorize the new MaintainerProxy in the ReimbursementPool (ReimbursementPool address is 0x8adF3f35dBE4026112bCFc078872bcb967732Ea8)
  • Authorize the SPV maintainer bot address in the new MaintainerProxy (SPV maintainer bot address is 0x0595acCca29654c43Bd67E18578b30a405265234)
  • Unauthorize the old MaintainerProxy in the Bridge (old MaintainerProxy is 0xcF29Ff894674775841F60Aa2a3c373DE27A8df2b)
  • Unauthorize the old MaintainerProxy in the ReimbursementPool
@lukasz-zimnoch lukasz-zimnoch added the ⛓️ solidity Solidity contracts label Jan 15, 2024
@lukasz-zimnoch lukasz-zimnoch self-assigned this Jan 15, 2024
@lukasz-zimnoch lukasz-zimnoch mentioned this issue Jan 16, 2024
Merged
@lukasz-zimnoch lukasz-zimnoch added this to the solidity/v1.5.2 milestone Jan 16, 2024
tomaszslabon added a commit that referenced this issue Jan 16, 2024
@tomaszslabon
[Backport] Add coinbase transaction proof to SPV proof (#770)
20a6fb1 
Refs: #769

This pull request backports changes developed as part of
GHSA-wg2x-rv86-mmpx
to the `releases/mainnet/solidity/v1.5.2` branch corresponding to the
`solidity/v1.5.2` release.

Release `solidity/v1.5.2` is a patch branched off from the currently
deployed `solidity/v1.5.1` version. Version `solidity/v1.5.2` could not
be branched off directly from `main` because `main` contains some
features that are not ready for release yet (e.g. removed
`WalletCoordinator`, added deposits with extra data). Those features
will be released as `solidity/v1.6.0` when the time comes.
This was referenced Jan 16, 2024
Merged
Merged
tomaszslabon added a commit that referenced this issue Jan 16, 2024
@tomaszslabon
Deployment artifacts after Bridge and MaintainerProxy upgrades (#771
0e6f4a5 
)

Refs: #769

New implementations of the `Bridge` and `MaintainerProxy` contracts were
deployed as part of the `solidity/v1.5.2` release. Here we update
deployment artifacts accordingly.
tomaszslabon added a commit that referenced this issue Jan 16, 2024
@tomaszslabon
[Backport] Deployment artifacts after Bridge and MaintainerProxy …
9f13e36 
…upgrades (#772)

Refs: #769

This pull request backports changes developed as part of
#771 to the
`releases/mainnet/solidity/v1.5.2` branch corresponding to the
`solidity/v1.5.2` release.
This was referenced Jan 18, 2024
Merged
Merged
tomaszslabon added a commit that referenced this issue Jan 18, 2024
@tomaszslabon
Update solcInputs directory (#774)
cac8a39 
Refs: #769

Here we add the missing `solcInputs` file related to the recent contract
upgrade.
tomaszslabon added a commit that referenced this issue Jan 18, 2024
@tomaszslabon
[Backport] Update solcInputs directory (#775)
5bae545 
Refs: #769

This PR backports changes from
#774 to the
`releases/mainnet/solidity/v1.5.2` branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukasz-zimnoch lukasz-zimnoch

Labels
⛓️ solidity Solidity contracts
Projects
None yet
Milestone
solidity/v1.5.2
Development

No branches or pull requests
1 participant
@lukasz-zimnoch