Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix finding wallets available for handling redemptions #812

Closed
michalinacienciala opened this issue Apr 19, 2024 · 0 comments · Fixed by #813
Closed

Fix finding wallets available for handling redemptions #812

michalinacienciala opened this issue Apr 19, 2024 · 0 comments · Fixed by #813
Assignees
@lukasz-zimnoch
Labels
🐛 bug Something isn't working 🔌 typescript TypeScript library
Milestone
typescript/v2.4.1

Comments

@michalinacienciala
Copy link
Contributor

We are not excluding terminated wallets when searching by the SDK for the wallets that could process the redemption request. Terminated wallets are removed from the contract registry, but on the current code they could still be chosen for redemption, resulting in the following error: Wallet with the given ID has not been registered.
@michalinacienciala michalinacienciala added the 🔌 typescript TypeScript library label Apr 19, 2024
@lukasz-zimnoch lukasz-zimnoch mentioned this issue Apr 22, 2024
Merged
@lukasz-zimnoch lukasz-zimnoch added this to the typescript/v2.4.1 milestone Apr 22, 2024
@lukasz-zimnoch lukasz-zimnoch added the 🐛 bug Something isn't working label Apr 22, 2024
tomaszslabon added a commit that referenced this issue Apr 22, 2024
@tomaszslabon
Improve public key fetching for closed/terminated wallets (#813)
51094e4 
Closes: #812

The current logic used to fetch wallet public keys was throwing errors
while used for `Closed` or `Terminated` wallets. This is because the
`WalletRegistry` contract does no longer hold the public key for such
wallets. In effect, the exception was propagated upstream and caused
problems while searching wallets for redemption.

Here we fix that problem by making the public key field optional and
keeping it undefined for closed/terminated wallets. That way, the client
code can detect this fact and omit closed/terminated wallets during
processing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukasz-zimnoch lukasz-zimnoch

Labels
🐛 bug Something isn't working 🔌 typescript TypeScript library
Projects
None yet
Milestone
typescript/v2.4.1
Development

Successfully merging a pull request may close this issue.

Improve public key fetching for closed/terminated wallets keep-network/tbtc-v2
2 participants
@lukasz-zimnoch @michalinacienciala