Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Implement OP_CHECKSIGADD #245

Open
b-j-roberts opened this issue Oct 4, 2024 · 2 comments
Open

[feat] Implement OP_CHECKSIGADD #245

b-j-roberts opened this issue Oct 4, 2024 · 2 comments
Assignees
@Jeanmichel7
Labels
enhancement New feature or request large/difficult issue

Comments

@b-j-roberts
Copy link
Contributor

b-j-roberts commented Oct 4, 2024 •
edited
Loading

The last remaining opcode in the engine to be implemented is OP_CHECKSIGADD.

Description
Three values are popped from the stack. The integer n is incremented by one and returned to the stack if the signature is valid for the public key and transaction. The integer n is returned to the stack unchanged if the signature is the empty vector (OP_0). In any other case, the script is invalid. This opcode is only available in tapscript.

NOTE
A large part of the work for OP_CHECKSIGADD had been done as part of this PR, but was closed due to time constraints. This could be a very good start.

We will need to implement the opcode and a set of tests.

References
@Jeanmichel7
Copy link
Contributor

I'm interested, can I finish it?

@b-j-roberts
Copy link
Contributor Author

@Jeanmichel7 Definitely, lmk if you have any questions, and good luck 🚀

This was referenced Oct 18, 2024
Closed
Closed
Merged
b-j-roberts added a commit that referenced this issue Oct 20, 2024
@Jeanmichel7 @b-j-roberts
[feat] Implement OP_CHECKSIGADD (#266)
34bad7b 
<!-- enter the gh issue after hash -->

- [x] issue #245 
- [x] follows contribution
[guide](https://github.com/keep-starknet-strange/shinigami/blob/main/CONTRIBUTING.md)
- [ ] code change includes tests

<!-- PR description below -->

---------

Co-authored-by: Brandon Roberts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jeanmichel7 Jeanmichel7

Labels
enhancement New feature or request large/difficult issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@b-j-roberts @Jeanmichel7