Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use URL hash to determine if on page that should be filled or not #1745

Closed
christophehenry opened this issue Oct 10, 2022 · 4 comments
Closed
Labels

Comments

@christophehenry
Copy link

Some… old school sites still use the #hash-part of the URL as a router (to keep support on IE11, I suppose). Namely Synology's web manager. This part does not seem to be considered as relevant by keepassxc-browser to determine wheter or not to fill a form. This result in keepassxc-browser filling every input it can on every page of the site which is a bit annoying.

Expected Behavior

If I specify https://example.com/#/login as a URL in KeepassXC, keepassxc-browser should fill form only when URL is https://example.com/#/login. Not https://example.com/ and not https://example.com/#/something-else

Current Behavior

The #hash-part is ignored by keepassxc-browser

Possible Solution

In case this clashes with a current desired behaviour, this can be a per-site option clearly accessible somewhere.

Steps to Reproduce (for bugs)

  1. Create a KeepassXC entry for a site that doesn't use hashes as router and add a hash part
  2. Go to the login page (don't add the hash part)
  3. keepassxc-browser should autofill the form even when the hash is not present

Debug info

KeePassXC - 2.7.1
KeePassXC-Browser - 1.8.2.2
Operating system: Linux
Browser: Firefox

@christophehenry christophehenry changed the title Use URL hash to determine if on page that should be filled on not Use URL hash to determine if on page that should be filled or not Oct 10, 2022
@varjolintu
Copy link
Member

Need to check this one what Qt does to the URL's. We remove fragments (URL parts at the end which start with #) from URL's for matching, but there's always a possibility that Qt detects those kind of paths as fragments.

@droidmonkey
Copy link
Member

Fragments should only be acknowledged with best matching credentials enabled. Also we do not recommend you enable auto fill off forms from the extension.

@christophehenry
Copy link
Author

christophehenry commented Oct 11, 2022

Also we do not recommend you enable auto fill off forms from the extension.

This causes problem especially for search inputs that performs some kind filtering. Then the extension always alters what's displayed.

Edit: the best matching credentials option does what I want. I still think there's an UX issue here as I had to open this ticket to be aware of that option and what it does. I don't really know how to solve it, though.

@varjolintu
Copy link
Member

This PR allows exact URL's and should solve the issue: keepassxreboot/keepassxc#9835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants