Prevent user from leaving unlock window by hitting ESC (#11199) #11221
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An alternative to the modal popup question is a warning message displayed: "Press ESC again to close this database" |
|
I got the first two points, @droidmonkey |
|
When |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11199
The issue is about to improve user experience. In case the user is about to unlock the database and hits the escape key while the password field is on focus, the unlock window would close.
From the user point of view the window should not be closed at that point. With current changes the unlock window will
not be closed anymore when hitting the escape key and instead a popup will open and asks if the user really wants to cancel the unlock process.
Open question:
I think these changes reflect the initial discussed solution for this issue.
The current process is the same when hitting the escape key or clicking on the "Close" button. In my opinion the workflow
might be fine when hitting ESC, but I don't think a further popup after clicking on "Close" would be necessary. Should this be changed?
Anything else that should be changed?
Screenshots
Testing strategy
Are tests for this kind of contribution expected?
Type of change