Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus search on unlocking database #2279

Closed
rugk opened this issue Sep 10, 2018 · 6 comments
Closed

Focus search on unlocking database #2279

rugk opened this issue Sep 10, 2018 · 6 comments

Comments

@rugk
Copy link

rugk commented Sep 10, 2018

(seen this behavior in the "original" KeePass)

Expected Behavior

Search should be focused.

Current Behavior

Something else is focused, I guess it's the first entry in the database.

Possible Solution

manually set focus

Steps to Reproduce (for bugs)

  1. Unlock database

Context

Use case: Quick search after unlocking database, usability.

@droidmonkey
Copy link
Member

droidmonkey commented Sep 11, 2018

Pressing CTRL+F focuses search. There are probably 50% of people who want an entry focused and 50% who want search focused. There is no hotkey to focus on first entry (maybe there should be?), perhaps a setting would suffice.

@rugk
Copy link
Author

rugk commented Sep 11, 2018

Hmm, is a setting really needed? I mean I do not see the use case for having an entry selected at startup. I'll guess nobody will use the arrow keys for navigating to an entry after start.
I just saw this behaviour in KeePass and liked it quite much.

@droidmonkey
Copy link
Member

Actually if you press down arrow in the search box it will select the first entry anyway, so we can easily change focus to search box on unlock without losing anything.

@droidmonkey droidmonkey self-assigned this Sep 11, 2018
@droidmonkey droidmonkey added this to the v2.4.0 milestone Sep 11, 2018
@droidmonkey
Copy link
Member

I would just like to point out that this is already the behavior! See here: https://github.com/keepassxreboot/keepassxc/blob/master/src/gui/SearchWidget.cpp#L123

@rugk
Copy link
Author

rugk commented Sep 13, 2018

Hmm, when I tested it in Fedora 28 it did not work, but maybe I'll need to test it again.

@TheZ3ro
Copy link
Contributor

TheZ3ro commented Sep 14, 2018

I confirm that the current behavior is:

  • Focus on Searchbar after unlock
  • Focus on the currently-selected entry when the down arrow is pressed in the searchbar

This is available since version 2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants