-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to select entry if window not found on auto-type #429
Comments
I like this proposal. I have several websites that I work on and have the same user/password to all of them. This way I can have the same credentials in the same entry. |
@schiorean Alternatively you can consider using #370 that is merged in develop |
Thanks will check it. When will #370 be released officially? EDIT: I still think it's a good idea to have the possibility to choose if no entry found. |
We don't have a release schedule for 2.2.0 yet. |
I really think this feature is very important, since many websites have the GENIUS idea to name their login pages "Login" or "Sign-in". And there goes auto-type. Fantastic! To keep things simple I would just show the select entry dialog as if it found an entry but without any entry and have a search field which provides the search text instead of window title. |
I think I'm starting to like this, with an option in the settings the "Select Entry Dialog" will show every entry in the database with autotype enabled and letting user search and select an entry. In some database there will be lot of entry with autotype enabled but the search feature can help. |
any updates on this? |
Is this being worked on by anyone? If not, I would love to start on it this week. |
Right now, I have the autotype dialog showing all entries if there are no matches, and I'm about to get started on the search functionality. I was wondering if it would be okay to also add the search to the regular autotype entry select dialog if it is tasteful and non-intrusive? That way, each case can use the same widget. Also, would you be okay with a checkbox in the widget (for when its shown with the all entries mode) that says something like "Create autotype association for '${WINDOW_TITLE}' in selected entry"? Or, this could instead be a dialog: "Create autotype association for '${WINDOW_TITLE}' in ${ENTRY}? [Yes] [No]" |
Yes please reduce variability. You can and should reuse the search widget and entry searcher |
Any updates @kneitinger ? |
@keckelt Coming along 🙂 I have a basic mechanism working, but there are still a few tasks left for it, as well as cleaning up the solution. |
Sorry for this work stalling out for a month, holidays followed by my workplace getting acquired led to an interesting and busy month. Picking this back up now 👍 |
any good news @kneitinger ? |
@zeteref It's going well! I just performance tested it on a 2000 entry database. Populating the window and searching were both perceptually instant 🙂. Also, I've unconditionally added the search to the AutoTypeSelectDialog, so even if matches were found for your window, you can still search through them if you'd like. @droidmonkey since you've worked quite extensively on the EntrySearcher, I have a question for you. Currently, the EntrySearcher does not search through auto type sequences, which makes total sense when searching in the database tab. I was wondering what your thoughts are on adding AutoTypeSequences as a Field that is optionally searchable... The use case I see for this is enabling very quick keyboard usage in the autotype select window. Imagine the case where you're trying to log in to Gmail... sometimes it asks for username/pw, sometimes username/pw/otp, sometimes just pw, and sometimes pw/otp. Imagine for this window title, the matching entry/sequences are:
GMail asks for username (and obv password), then after that it decided it was feeling an OTP today. The user can very quickly do:
without having to read the entries very carefully. One way I can see this happening non-obtrusively is to have a default setting where existing searches avoid autotype sequences, with the setting being changed via an optional constructor param:
How do you feel about that? |
You can just add Auto-Type as a search field (eg, autotype:"sequence") |
@kneitinger sounds great - and addition of searching through auto type sequences is making this feature even more usefull. Can't wait to test it! |
Happy to hear that! Functionally, I'm quite happy with it, and now I'm working on usability/UX of it, mainly in the context of reasonable and useful keyboard interaction. What I'm going for is:
It's close, but there are a couple of those cases that aren't quite right yet. |
seems reasonable. |
This is the only feature which keeps me from changing to keepassxc. |
This feature is easily overcome by just defining window associations with the entries. You can use wildcards to make matching more forgiving. |
While this is true for the given use case above, what about auto-typing e.g. in the terminal? It is nice to have a filterable list coming up from where one can choose the right entry. Or other non-simple to distinguish windows. |
no, KeePass uses Ctrl+Alt+Shift+A differently; they only auto-type the password in this case. Please don't use that same shortcut for something different. |
I'm doing exactly this with the AutoTypeSearch plugin in keepass2, in my case it's |
I like this idea |
Significant improvements to the Auto-Type select dialog. Reduce stale and unnecessary code paths. * Close select dialog when databases are locked. * Only filter based on Group, Title, and Username column data * Always show the sequence column (revert feature) * Close #3630 - Allow typing {USERNAME} and {PASSWORD} from selection dialog (right-click menu). * Close #429 - Ability to search open databases for an entry from the Auto-Type selection dialog.
Significant improvements to the Auto-Type select dialog. Reduce stale and unnecessary code paths. * Close select dialog when databases are locked. * Only filter based on Group, Title, and Username column data * Always show the sequence column (revert feature) * Close #3630 - Allow typing {USERNAME} and {PASSWORD} from selection dialog (right-click menu). * Close #429 - Ability to search open databases for an entry from the Auto-Type selection dialog.
Significant improvements to the Auto-Type select dialog. Reduce stale and unnecessary code paths. * Close select dialog when databases are locked. * Only filter based on Group, Title, and Username column data * Always show the sequence column (revert feature) * Close #3630 - Allow typing {USERNAME} and {PASSWORD} from selection dialog (right-click menu). * Close #429 - Ability to search open databases for an entry from the Auto-Type selection dialog.
Significant improvements to the Auto-Type select dialog. Reduce stale and unnecessary code paths. * Close select dialog when databases are locked. * Close open modal dialogs prior to showing the Auto-Type select dialog to prevent interference. * Never perform Auto-Type on the KeePassXC window. * Only filter match list based on Group, Title, and Username column data (ie, ignore sequence column) * Always show the sequence column (revert feature) * Show selection dialog if there are no matches to allow for a database search * Close #3630 - Allow typing {USERNAME} and {PASSWORD} from selection dialog (right-click menu). * Close #429 - Ability to search open databases for an entry from the Auto-Type selection dialog.
Significant improvements to the Auto-Type select dialog. Reduce stale and unnecessary code paths. * Close select dialog when databases are locked. * Close open modal dialogs prior to showing the Auto-Type select dialog to prevent interference. * Never perform Auto-Type on the KeePassXC window. * Only filter match list based on Group, Title, and Username column data (ie, ignore sequence column) * Always show the sequence column (revert feature) * Show selection dialog if there are no matches to allow for a database search * Close #3630 - Allow typing {USERNAME} and {PASSWORD} from selection dialog (right-click menu). * Close #429 - Ability to search open databases for an entry from the Auto-Type selection dialog.
Significant improvements to the Auto-Type select dialog. Reduce stale and unnecessary code paths. * Close select dialog when databases are locked. * Close open modal dialogs prior to showing the Auto-Type select dialog to prevent interference. * Never perform Auto-Type on the KeePassXC window. * Only filter match list based on Group, Title, and Username column data (ie, ignore sequence column) * Always show the sequence column (revert feature) * Show selection dialog if there are no matches to allow for a database search * Close #3630 - Allow typing {USERNAME} and {PASSWORD} from selection dialog (right-click menu). * Close #429 - Ability to search open databases for an entry from the Auto-Type selection dialog.
Significant improvements to the Auto-Type select dialog. Reduce stale and unnecessary code paths. * Close select dialog when databases are locked. * Close open modal dialogs prior to showing the Auto-Type select dialog to prevent interference. * Never perform Auto-Type on the KeePassXC window. * Only filter match list based on Group, Title, and Username column data (ie, ignore sequence column) * Always show the sequence column (revert feature) * Show selection dialog if there are no matches to allow for a database search * Close #3630 - Allow typing {USERNAME} and {PASSWORD} from selection dialog (right-click menu). * Close #429 - Ability to search open databases for an entry from the Auto-Type selection dialog. * Fix #5361 - Default size of selection dialog doesn't cut off matches
Significant improvements to the Auto-Type select dialog. Reduce stale and unnecessary code paths. * Close select dialog when databases are locked. * Close open modal dialogs prior to showing the Auto-Type select dialog to prevent interference. * Never perform Auto-Type on the KeePassXC window. * Only filter match list based on Group, Title, and Username column data (ie, ignore sequence column) * Always show the sequence column (revert feature) * Show selection dialog if there are no matches to allow for a database search * Close #3630 - Allow typing {USERNAME} and {PASSWORD} from selection dialog (right-click menu). * Close #429 - Ability to search open databases for an entry from the Auto-Type selection dialog. * Fix #5361 - Default size of selection dialog doesn't cut off matches
Significant improvements to the Auto-Type select dialog. Reduce stale and unnecessary code paths. * Close select dialog when databases are locked. * Close open modal dialogs prior to showing the Auto-Type select dialog to prevent interference. * Never perform Auto-Type on the KeePassXC window. * Only filter match list based on Group, Title, and Username column data (ie, ignore sequence column) * Always show the sequence column (revert feature) * Show selection dialog if there are no matches to allow for a database search * Close #3630 - Allow typing {USERNAME} and {PASSWORD} from selection dialog (right-click menu). * Close #429 - Ability to search open databases for an entry from the Auto-Type selection dialog. * Fix #5361 - Default size of selection dialog doesn't cut off matches
Significant improvements to the Auto-Type select dialog. Reduce stale and unnecessary code paths. * Close select dialog when databases are locked. * Close open modal dialogs prior to showing the Auto-Type select dialog to prevent interference. * Never perform Auto-Type on the KeePassXC window. * Only filter match list based on Group, Title, and Username column data (ie, ignore sequence column) * Always show the sequence column (revert feature) * Show selection dialog if there are no matches to allow for a database search * Close #3630 - Allow typing {USERNAME} and {PASSWORD} from selection dialog (right-click menu). * Close #429 - Ability to search open databases for an entry from the Auto-Type selection dialog. * Fix #5361 - Default size of selection dialog doesn't cut off matches
Significant improvements to the Auto-Type select dialog. Reduce stale and unnecessary code paths. * Close select dialog when databases are locked. * Close open modal dialogs prior to showing the Auto-Type select dialog to prevent interference. * Never perform Auto-Type on the KeePassXC window. * Only filter match list based on Group, Title, and Username column data (ie, ignore sequence column) * Always show the sequence column (revert feature) * Show selection dialog if there are no matches to allow for a database search * Close #3630 - Allow typing {USERNAME} and {PASSWORD} from selection dialog (right-click menu). * Close #429 - Ability to search open databases for an entry from the Auto-Type selection dialog. * Fix #5361 - Default size of selection dialog doesn't cut off matches
Significant improvements to the Auto-Type select dialog. Reduce stale and unnecessary code paths. * Close select dialog when databases are locked. * Close open modal dialogs prior to showing the Auto-Type select dialog to prevent interference. * Never perform Auto-Type on the KeePassXC window. * Only filter match list based on Group, Title, and Username column data (ie, ignore sequence column) * Always show the sequence column (revert feature) * Show selection dialog if there are no matches to allow for a database search * Close #3630 - Allow typing {USERNAME} and {PASSWORD} from selection dialog (right-click menu). * Close #429 - Ability to search open databases for an entry from the Auto-Type selection dialog. * Fix #5361 - Default size of selection dialog doesn't cut off matches
Significant improvements to the Auto-Type select dialog. Reduce stale and unnecessary code paths. * Close select dialog when databases are locked. * Close open modal dialogs prior to showing the Auto-Type select dialog to prevent interference. * Never perform Auto-Type on the KeePassXC window. * Only filter match list based on Group, Title, and Username column data (ie, ignore sequence column) * Always show the sequence column (revert feature) * Show selection dialog if there are no matches to allow for a database search * Close #3630 - Allow typing {USERNAME} and {PASSWORD} from selection dialog (right-click menu). * Close #429 - Ability to search open databases for an entry from the Auto-Type selection dialog. * Fix #5361 - Default size of selection dialog doesn't cut off matches
Significant improvements to the Auto-Type select dialog. Reduce stale and unnecessary code paths. * Close select dialog when databases are locked. * Close open modal dialogs prior to showing the Auto-Type select dialog to prevent interference. * Never perform Auto-Type on the KeePassXC window. * Only filter match list based on Group, Title, and Username column data (ie, ignore sequence column) * Always show the sequence column (revert feature) * Show selection dialog if there are no matches to allow for a database search * Close #3630 - Allow typing {USERNAME} and {PASSWORD} from selection dialog (right-click menu). * Close #429 - Ability to search open databases for an entry from the Auto-Type selection dialog. * Fix #5361 - Default size of selection dialog doesn't cut off matches
Significant improvements to the Auto-Type select dialog. Reduce stale and unnecessary code paths. * Close select dialog when databases are locked. * Close open modal dialogs prior to showing the Auto-Type select dialog to prevent interference. * Never perform Auto-Type on the KeePassXC window. * Only filter match list based on Group, Title, and Username column data (ie, ignore sequence column) * Always show the sequence column (revert feature) * Show selection dialog if there are no matches to allow for a database search * Close keepassxreboot#3630 - Allow typing {USERNAME} and {PASSWORD} from selection dialog (right-click menu). * Close keepassxreboot#429 - Ability to search open databases for an entry from the Auto-Type selection dialog. * Fix keepassxreboot#5361 - Default size of selection dialog doesn't cut off matches
Check out the milestone for this feature |
Maybe I'm blind but I don't see anything that specifically mentions this problem, do you have a link? |
This isn't being released until version 2.7.0 |
This is a feature request.
Expected Behavior
Current Behavior
instead of 4. there is a warning message like "could not find an entry with matching window title", which can only be dismissed with "OK".
Possible Solutions
git
, which displays entries for github and gitlab, then use the arrow keys to select the one you want, then press enter to select & auto-type it.Your Environment
The text was updated successfully, but these errors were encountered: