Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Reference is not resolved after cloning an entry #615

Closed
ftes opened this issue Jun 1, 2017 · 4 comments
Closed

Bug: Reference is not resolved after cloning an entry #615

ftes opened this issue Jun 1, 2017 · 4 comments

Comments

@ftes
Copy link

ftes commented Jun 1, 2017

#370 adds support for references.

However, after cloning an entry and generating references, these references are not resolved on copy to clipboard, http and auto type.

The problem seems to be that the UUID in the reference is uppercase, while the UUID of the source entry is lowercase. This breaks the resolving of the reference.

See #370 (review)

Workaround

Manually edit the reference so that the UUID is lowercase. Then resolving works as expected.

Expected Behavior

References in a cloned entry should be resolved when copying/auto-typing etc.

Current Behavior

When copying/auto-typing referenced fields, the reference itself is output. E.g. after copying a password field the clipboard holds {REF:P@I:8266fe15f28dc2be0698b26ac9d785f8}.

Possible Solution

Use same case (uppercase/lowercase) for UUIDs when

  • generating fresh UUIDs for new entries and
  • references that include UUIDs to existing references

Steps to Reproduce (for bugs)

  1. create a new entry
  2. clone the new entry and select Replace username and password with references in dialog
  3. do a Ctrl+c on the cloned entry (copy password to clipboard)
  4. inspect the clipboard content
@ftes
Copy link
Author

ftes commented Jun 1, 2017

@mrrsm maybe you have an idea for an easy fix.

@TheZ3ro
Copy link
Contributor

TheZ3ro commented Jun 1, 2017

I cannot reproduce this with xUbuntu on the latest develop version.
Using both uppercase and lowercase hex UUID is fine for me.

@ftes
Copy link
Author

ftes commented Jun 1, 2017

@TheZ3ro thanks for checking.
Update from my side: after reinstalling everything works for me now (switched back and forth between AUR version which uses develop branch and the official Arch repo).

Maybe this happened due to some weird intermediate state that a reboot would also have fixed. I will keep an eye on it and close the issue for now.

@ftes ftes closed this as completed Jun 1, 2017
@TheZ3ro
Copy link
Contributor

TheZ3ro commented Jun 1, 2017

Ok thanks @ftes anyway for the report 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants