Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add support for basic references in autotype #75

Closed
meisanerd opened this issue Nov 3, 2016 · 9 comments · Fixed by #370
Closed

Feature: Add support for basic references in autotype #75

meisanerd opened this issue Nov 3, 2016 · 9 comments · Fixed by #370
Assignees
Milestone

Comments

@meisanerd
Copy link

In the source keypassx github, there is a pull request for adding some of the basic keepass references into autotype. Is it possible to get that PR merged into this fork?
keepassx/keepassx#184

Expected Behavior

On Amazon.ca, I should be able to autotype/fill from ChromeIPass the records from amazon.com, as the u/p combo is stored as {REF:U@I:AMAZON.COM_UUID} and {REF:P@I:AMAZON.COM_UUID}

Current Behavior

It sends the strings (ie: {REF:U@I:AMAZON.COM_UUID}) instead of the u/p specified in the amazon.com reference

Possible Solution

Copy the pull request from the keepassx github and merge it in

Context

Amazon.com and Amazon.ca both use the same credentials, but as they are using different URLs, they are seen as different sites to Keepass/KeepassX and ChromeIPass. Keepass on Windows manages this by allowing you to create 2+ separate entries, one containing the real values, the other containing a reference via UUID to the first one (http://keepass.info/help/base/fieldrefs.html).

@TheZ3ro
Copy link
Contributor

TheZ3ro commented Feb 12, 2017

This should also have a nice GUI like discussed in #274

@mrrsm
Copy link
Contributor

mrrsm commented Mar 1, 2017

@TheZ3ro Is this something you are working on? If not I can clean up my code for this and make a PR.

@droidmonkey
Copy link
Member

Does it have a nice GUI interface as described in my last comment on #274?

@mrrsm
Copy link
Contributor

mrrsm commented Mar 1, 2017

My current changes create a popup when you clone an entry which gives you the option for references (along with a few other things). http://imgur.com/a/nYeYs
This works similar to how KeePass does it at least.

I should be able to change the edit entry page to pick a custom entry to reference as well if that is how you would like it to work. At least in my use cases I rarely make a current entry a reference but instead create the reference on clone.

@TheZ3ro
Copy link
Contributor

TheZ3ro commented Mar 1, 2017

@mrrsm currently I'm not working on it. I like the clone with reference idea and if it's the KeePass behavior I think we should go for it.
Unfortunately this is limited to Username and Password. I agree that most of the case that are the only useful field to reference but every field should be available for reference.
Maybe adding a nice gui/dialog for selecting references with a button next to the field should be the next step.

@droidmonkey
Copy link
Member

@mrrsm that looks great and a good idea to put it with cloning.

@mrrsm
Copy link
Contributor

mrrsm commented Mar 2, 2017

So where would you want to have the settings for cloning other fields? I was looking into that last night and the only option that didn't seem too obtrusive was to define in the settings globally what fields will get transferred as references when you clone. This would then turn the replace username/password with replace fields with references. My use case is just for user/pass references and I mimicked what KeePass 2.x had however I agree it could probably be improved upon.
The final option would be me pushing what I have now and we can make a new task to add additional pieces as we determine how they should work.

@phoerious
Copy link
Member

Make a PR with a couple of screenshots against develop and we'll work it out.

@TheZ3ro
Copy link
Contributor

TheZ3ro commented Mar 2, 2017

What I was saying is. The reference used with KeePass syntax (see first post) needs to be available in all the fields.
If I enter in an entry URL {REF:A@I:9831} I expect to refer to the 9831 entry's URL.
The reference-parsing code should be enabled on all the entry's field. (like in https://github.com/keepassx/keepassx/pull/184/files)

Then when cloning user can automatically use reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants