Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable escape key to cancel Quick Unlock #7892

Closed
OlivierMary opened this issue Apr 14, 2022 · 9 comments · Fixed by #9697
Closed

Enable escape key to cancel Quick Unlock #7892

OlivierMary opened this issue Apr 14, 2022 · 9 comments · Fixed by #9697
Assignees
@droidmonkey
Labels
feature: QuickUnlock
Milestone
v2.7.6

Comments

@OlivierMary
Copy link

Summary

Hi,

Problem

In Quick Unlock database and Unlock Database if TouchId is enabled we have to click with mouse on "Cancel" button to get password input text if TouchId is inaccessible for any reason.

Example

  • If I use my laptop open all good I have access to TouchId and unlock faster than enter password.

  • But, if I use my mac/laptop with external keyboard and screen I didn't have access to TouchId, cause I close my laptop.
    So I have to left my keyboard to take the mouse and go click on cancel, and go back to keyboard to enter my password.

Some proposals

  • Keep both section in popup at same time by default (TouchId and 'Normal' unlock)
  • Same but with option in preferences if needed
  • ESC can switch TouchId to 'Normal' unlock, if already in 'Normal' unlock like actually that close popup
@droidmonkey
Copy link
Member

droidmonkey commented Apr 14, 2022 •
edited
Loading

Does pressing TAB then Enter (maybe space) not work for you?

@michaelk83
Copy link

It is usually expected that Esc triggers the Cancel button in dialogs.

@OlivierMary
Copy link
Author

@droidmonkey

Hum, that work but not intuitive.

@michaelk83 +1

@droidmonkey droidmonkey changed the title Let visible input text for password to unlock database if TouchId enable Enable escape key to cancel Quick Unlock Apr 14, 2022
@droidmonkey droidmonkey self-assigned this Apr 14, 2022
@koichirose
Copy link

Possibly related: in my opinion it shouldn't even show the option to unlock with TouchID if the laptop lid is closed.

@OlivierMary
Copy link
Author

@koichirose yes but don't know if possible to check it

@nanaya
Copy link

nanaya commented Jul 27, 2023

Not specifically about touchid but I think it would be nice if the lock screen gives option between quick unlock and password unlock, and keeping the quick unlock option even after unlocking using password.

In my use case it's for when I access keepassxc through remote desktop (windows) I need to use password unlock but when I'm back at my desktop I'd like to be able to use quick unlock without having to reenter the password again.

@droidmonkey droidmonkey added this to the v2.7.6 milestone Aug 6, 2023
droidmonkey added a commit that referenced this issue Aug 6, 2023
@droidmonkey
Fix several issues with Quick Unlock
59d8be2 
* Fix #7892 - Pressing escape when the quick unlock prompt is shown will now go back to the main unlock dialog view.
* Fix #9030 - Quick unlock will be automatically invoked in the unlock dialog upon being shown.
* Fix #9554 - Quick unlock application setting will be updated every time the settings widget is shown instead of just on first launch.
droidmonkey added a commit that referenced this issue Aug 6, 2023
@droidmonkey
Fix several issues with Quick Unlock
fb84877 
* Fix #7892 - Pressing escape when the quick unlock prompt is shown will now go back to the main unlock dialog view.
* Fix #9030 - Quick unlock will be automatically invoked in the unlock dialog upon being shown.
* Fix #9554 - Quick unlock application setting will be updated every time the settings widget is shown instead of just on first launch.

* Show warning that quick unlock is not enabled if user cancels Windows Hello prompt. This should limit people thinking there is a security issue.

* Disable quick unlock in gui tests
@droidmonkey droidmonkey mentioned this issue Aug 6, 2023
Merged
droidmonkey added a commit that referenced this issue Aug 6, 2023
@droidmonkey
Fix several issues with Quick Unlock
0d54361 
* Fix #7892 - Pressing escape when the quick unlock prompt is shown will now go back to the main unlock dialog view.
* Fix #9030 - Quick unlock will be automatically invoked in the unlock dialog upon being shown.
* Fix #9554 - Quick unlock application setting will be updated every time the settings widget is shown instead of just on first launch.

* Show warning that quick unlock is not enabled if user cancels Windows Hello prompt. This should limit people thinking there is a security issue. Also improve documentation describing this behavior.

* Disable quick unlock in gui tests
droidmonkey added a commit that referenced this issue Aug 6, 2023
@droidmonkey
Fix several issues with Quick Unlock
0fcd3fd 
* Fix #7892 - Pressing escape when the quick unlock prompt is shown will now go back to the main unlock dialog view.
* Fix #9030 - Quick unlock will be automatically invoked in the unlock dialog upon being shown.
* Fix #9554 - Quick unlock application setting will be updated every time the settings widget is shown instead of just on first launch.

* Show warning that quick unlock is not enabled if user cancels Windows Hello prompt. This should limit people thinking there is a security issue. Also improve documentation describing this behavior.

* Disable quick unlock in gui tests
@foss-
Copy link

foss- commented Aug 7, 2023

Possibly related: in my opinion it shouldn't even show the option to unlock with TouchID if the laptop lid is closed.

Agreed. Detection whether lid is open or closed is possible and this 1Password unlock dialog instantly reflected the changed state. Screenshot is with lid closed. Once the lid is opened TouchID option is added back to the dialog.
1

@droidmonkey
Copy link
Member

That is tracked on a separate issue. Thank you

@foss-
Copy link

foss- commented Aug 7, 2023

Sorry, you are right. For reference: #8105

droidmonkey added a commit that referenced this issue Aug 10, 2023
@droidmonkey
Fix several issues with Quick Unlock (#9697)
eee25a1 
* Fix #7892 - Pressing escape when the quick unlock prompt is shown will now go back to the main unlock dialog view.
* Fix #9030 - Quick unlock will be automatically invoked in the unlock dialog upon being shown.
* Fix #9554 - Quick unlock application setting will be updated every time the settings widget is shown instead of just on first launch.

* Show warning that quick unlock is not enabled if user cancels Windows Hello prompt. This should limit people thinking there is a security issue. Also improve documentation describing this behavior.

* Disable quick unlock in gui tests
droidmonkey added a commit that referenced this issue Aug 14, 2023
@droidmonkey
Fix several issues with Quick Unlock (#9697)
aecd154 
* Fix #7892 - Pressing escape when the quick unlock prompt is shown will now go back to the main unlock dialog view.
* Fix #9030 - Quick unlock will be automatically invoked in the unlock dialog upon being shown.
* Fix #9554 - Quick unlock application setting will be updated every time the settings widget is shown instead of just on first launch.

* Show warning that quick unlock is not enabled if user cancels Windows Hello prompt. This should limit people thinking there is a security issue. Also improve documentation describing this behavior.

* Disable quick unlock in gui tests
evur pushed a commit to BrokenMS/keepassxc that referenced this issue Aug 23, 2023
@droidmonkey @evur
Fix several issues with Quick Unlock (keepassxreboot#9697)
6637727 
* Fix keepassxreboot#7892 - Pressing escape when the quick unlock prompt is shown will now go back to the main unlock dialog view.
* Fix keepassxreboot#9030 - Quick unlock will be automatically invoked in the unlock dialog upon being shown.
* Fix keepassxreboot#9554 - Quick unlock application setting will be updated every time the settings widget is shown instead of just on first launch.

* Show warning that quick unlock is not enabled if user cancels Windows Hello prompt. This should limit people thinking there is a security issue. Also improve documentation describing this behavior.

* Disable quick unlock in gui tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@droidmonkey droidmonkey

Labels
feature: QuickUnlock
Projects
None yet
Milestone
v2.7.6
Development

Successfully merging a pull request may close this issue.

Fix several issues with Quick Unlock keepassxreboot/keepassxc
6 participants
@nanaya @koichirose @droidmonkey @OlivierMary @michaelk83 @foss-