Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong menu location in user alert #9767

Closed
genseirin opened this issue Aug 20, 2023 · 5 comments · Fixed by #9783
Closed

Wrong menu location in user alert #9767

genseirin opened this issue Aug 20, 2023 · 5 comments · Fixed by #9783

Comments

@genseirin
Copy link

Overview

When trying to fetch a favicon and the settings are not enabled, you see
Unable to fetch favicon. You can enable the DuckDuckGo website icon service under Tools -> Settings -> Security
On a Mac this location is not correct.

Steps to Reproduce

  1. Make sure that "Use DuckDuckGo service to download website icons is disabled"
  2. Edit an entry
  3. Go to Icon tab
  4. Click "Download favicon"

Expected Behavior

The user expects to find the menu at the indicated location.

Actual Behavior

The menu location is under „Preferences“.

Context

KeePassXC - Version 2.7.6
Revision: dd21def

Operating system: macOS 11.7
CPU architecture: arm64
Kernel: darwin 20.6.0

@droidmonkey
Copy link
Member

It should just say "Application Settings -> Security"

@8manz
Copy link
Contributor

8manz commented Aug 23, 2023

Do I have to edit the files in share/translations to change the message? If so, I assume I just change the sources since you would need someone more qualified for proper translations or for someone else to take this on.

@droidmonkey
Copy link
Member

Just the sources

@hsm2k3
Copy link

hsm2k3 commented Aug 29, 2023

has this been fixed? Looks like #9783 didn't merge

@droidmonkey
Copy link
Member

No the PR is still open...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants