Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle other file types except images #1

Open
1 of 5 tasks
jancborchardt opened this issue Apr 4, 2018 · 3 comments
Open
1 of 5 tasks

Handle other file types except images #1

jancborchardt opened this issue Apr 4, 2018 · 3 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@jancborchardt
Copy link
Member

jancborchardt commented Apr 4, 2018

Currently only images are shown and the app doesn’t start if the shuffled filelist begins with a non-image.

Steps to take to fix this:

  • A first step would be to simply skip non-images
  • Show a notice in the interface
  • Show the non-images with empty preview box
  • Show filetype icons for non-image files
  • Show previews for other files where possible. Text files should be easy with canvas too
@jancborchardt jancborchardt added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Apr 4, 2018
jancborchardt added a commit that referenced this issue Apr 4, 2018
@jancborchardt jancborchardt added this to the 0.2.0 milestone Apr 7, 2018
@jancborchardt jancborchardt added the help wanted Extra attention is needed label Apr 7, 2018
@prashantsengar prashantsengar self-assigned this Jun 26, 2019
@prashantsengar
Copy link
Member

  • Show the non-images with empty preview box
  • Show filetype icons for non-image files
  • Show thumbnail for video files
  • Show previews for other files where possible. Text files should be easy with canvas too

@prashantsengar
Copy link
Member

@jancborchardt I need your help. When showing the thumbnail for a video, I will create a thumbnail using PIL by saving a frame to a temporary thumbnail folder. Should I leave the thumbnail folder with the thumbnail files in it or should I delete the thumbnail file once the video file is handled by the user?

@jancborchardt
Copy link
Member Author

jancborchardt commented Jul 16, 2019

Should I leave the thumbnail folder with the thumbnail files in it or should I delete the thumbnail file once the video file is handled by the user?

I’d say remove the thumbnail once it’s handled, doesn’t matter if kept or swept. Otherwise we create more files on people’s machines. :D

And the temporary thumbnail folder is hidden, right? (Like in .config or smth?)

And nice on the preview generation! 🎉

prashantsengar added a commit to prashantsengar/keeporsweep-desktop that referenced this issue Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants