Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw the exception only when an email is about to be sent #1

Open
jlaute opened this issue Feb 6, 2023 · 1 comment
Open

Throw the exception only when an email is about to be sent #1

jlaute opened this issue Feb 6, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@jlaute
Copy link

jlaute commented Feb 6, 2023

Hey Guys,

first of all thank you for this plugin. It can be a life saver when someone has imported some staging/live database and forgets to reset the mailer config.

I do not have a real issue with the plugin, but instead I would suggest to not break the whole shop when a mailer config is not set correctly. Maybe it would be better to have some big warnings in front- and backend instead of throwing an exception globally. Throwing the exception just when some E-Mail is about to be sent is enough in my opinion.

@kleinmann
Copy link
Member

Hi @jlaute, this seems like a reasonable change, thanks for suggesting 🙂
In this first iteration, a crash&burn handling was sufficient for us to remove any doubt of an invalid mail configuration. It can be disruptive with database imports, I agree 🙂

Are you interested in preparing a pull request for this? Otherwise it may be some time until we get around to this.
Something to keep in mind: It is still important to me, that any action in the Storefront, Administration and Console notifies the user about the wrong configuration.

@kleinmann kleinmann added the enhancement New feature or request label Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants