Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up bluetooth-classic-example #1

Open
kenjdavidson opened this issue Jan 14, 2021 · 9 comments
Open

Clean up bluetooth-classic-example #1

kenjdavidson opened this issue Jan 14, 2021 · 9 comments

Comments

@kenjdavidson
Copy link
Owner

Needs to be cleaned up, maybe a full overhaul making it more usable as an actual application.

  • Make the move to hooks/functions
  • Redesign the application screens for consistency
  • Redesign the state management

Serial Terminal is the defacto bluetooth serial app. In no way is this app meant to replace (or come close) but it has some nice things that would showcase the Bluetooth React Library.
@khali70
Copy link

khali70 commented Oct 7, 2021 •
edited
Loading

after i couldn't run the example i made a new RN app and added the src , app.js

the repo here

then after i get working app i made app.js and devices-list.js Hooks/functions

@kenjdavidson i hope you took a look at the repo or tell me how can i help

@kenjdavidson
Copy link
Owner Author

kenjdavidson commented Oct 7, 2021 via email

@khali70
Copy link

khali70 commented Oct 7, 2021

it's outside the issue but why in you send buffer array also
buffer blc

@kenjdavidson
Copy link
Owner Author

kenjdavidson commented Oct 7, 2021 via email

@khali70
Copy link

khali70 commented Oct 7, 2021

thanks for the responding MR.kenjdavidson

the data is just string contains numbers no hex numbers

we working on graduation project to help people with disability of talking (silent people) to talk with glove that get hand signs and mobile app to speak for them

we use classic bluetooth module to connect react-native app with arduino hardware and the glove

@kenjdavidson
Copy link
Owner Author

kenjdavidson commented Oct 7, 2021 via email

@kenjdavidson
Copy link
Owner Author

With regards to the comment that you've attached data - this was probably done while testing an issue. As I've mentioned this is my DEVELOPMENT application and may not work based on the current configuration. I use it when:

  • Debugging requests for bugs and features
  • Testing out new functionality I want to try

It should be used as a reference only and not thought of as the gospel of how an application should be created.

@khali70
Copy link

khali70 commented Oct 7, 2021

Your sample app seems good and working. Feel free to pr it into the samples if it does something that you think would be a good
teachable/lesson for people . But it will not replace the current example app.

where is the sample repo to make a pr after i finish the app

@kenjdavidson
Copy link
Owner Author

It's this repository. Just create your app in a subfolder of this directory. Document it with the reasons why it was added and what "example" it is providing that someone may need to see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kenjdavidson @khali70