Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve warning "No namespace detected" for files with hidden packages #3

Closed
dolmen opened this issue Jan 9, 2015 · 3 comments
Closed

Comments

@dolmen
Copy link

dolmen commented Jan 9, 2015

When ones want to hide a package from indexing using the package \n Foo; trick, those files are reported as "No namespace detected". This is correct, but the impression the message gives is that is an error that has to be fixed while this is in fact exactly what the author wants. This is somewhat a kind of false positive that may be confusing for other contributors to that project.

It would be more useful to report that the file has namespaces, but that they are explicitely hidden, and may be report this only while in verbose/debug mode.

See also dagolden/Dist-Zilla-Plugin-BumpVersionAfterRelease#7 that is somewhat related.

@kentfredric
Copy link
Member

This is slightly challenging to do, for the layer I'm at, I'm simply using Module::Metadata to determine namespace existence and not.

Module::Metadata is what is responding to the package \n Foo trick, and so that conclusion is squirrelled away from me prior to it being something I can check for.

I'd gladly fix this if there's a viable workaround though, I'd just need to know how to do so reliably.

@kentfredric
Copy link
Member

@dolmen
Copy link
Author

dolmen commented Jan 12, 2015

Fixed in e6ee0ca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants