-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KerasCV Fix-it ⚒️ #2211
Comments
I'm excited to take these on. I'll be sending PRs on these after a week. Thanks! |
Will work on a few of these @ID6109 which ones will you be working on? |
@soma2000-lang and @ID6109 Thank you for you interest. I wanted to add an update. We have decided to keep the preprocessing layers TF only for now. So, I have updated the list above. |
I see @divyashreepathihalli. Then perhaps it was good that we waited a bit to initiate the conversions. @soma2000-lang, how about you start from the bottom? I'll begin by starting from the top. |
Sure @ID6109 works for me. |
@soma2000-lang @ID6109 I'll be starting from the middle |
@sami-bg yeah, let us leave the examples with custom implementation to the last. |
@divyashreepathihalli , For Handwriting recognition, |
@sayakpaul , For |
|
Thanks Sachin! marked it as done |
I will work on |
Thank you I will mark it as yours. |
@IMvision12 in this example here - can you please add the details on what dataset you are using for the YOLO example here - https://keras.io/examples/vision/yolov8/ |
I am trying to migrate retinanet notebook, are there any alternatives that can be used for Thanks |
@sineeli you can use the preprocessing layers for that
We also have additional image ops here - https://keras.io/api/ops/image/ |
@divyashreepathihalli it seems |
Hi @divyashreepathihalli you can use this to load data !gdown 19CWdNL3ePq9XIgMeb_RjA641iGra3nWm
!unzip data.zip and update the code for loading the data # Path to images and annotations
path_images = "./data/images/"
path_annot = "./data/annotations/" |
thank you @IMvision12! |
Hi @divyashreepathihalli |
Learnable resizer: keras-team/keras-io#1688 |
@divyashreepathihalli I would like to take up the Efficient Object Detection with YOLOV8 and KerasCV example. |
Thanks @sitamgithub-MSIT - please also take a look at this comment for updating the example - #2211 (comment) |
I tried the shiftvit [TF only] (A Vision Transformer without Attention) example with Keras 3. After a few changes, it is working fine. I will make a PR soon regarding that. |
I have migrated the |
@divyashreepathihalli Apart from these examples, there are some examples I tried out for which a problem appeared: a missing dataset. For example, the public dataset link does not exist right now. Or if data is taken from the GCP bucket, it does not exist. Should I mark them then anywhere? |
Also, some of our examples, I worked I see the PR already exists, but somehow it's been a month since the contributor added those changes to the example.py file. It is not merged due to the fact that .ipynb and .md files are not generated. What should we do in those cases? |
Yes, I do know about this one, can you share what dataset you are talking about? We might be able to find a mirror site. |
Please do respond on that PR that you would like to take it up. |
Classification with Gated Residual and Variable Selection Networks In this example, the dataset currently does not exist. How to train a Keras model on TFRecord files In this example, the GCS bucket does not exist at present. |
@divyashreepathihalli It is possible to replace certain TF ops or numpy ops used in older examples that were converted to Keras 3 with equivalent Keras ops without experiencing any issues with the code's overall functionality. So, are those in need of any modifications? Since the examples are ultimately operating properly with those unaltered tf or np ops using the designated backends. |
@sitamgithub-MSIT we should be replaceing all tf ops with keras ops and the functionality should still be the same. I did not quite understand your second question? do you have an example? |
@sitamgithub-MSIT > Classification with Gated Residual and Variable Selection Networks In this example, the dataset currently does not exist. |
For example, this section of code from this keras 3 code example Simple MNIST convnet
Here, Another one from this keras 3 code example is Image classification via fine-tuning with EfficientNet
Here is also So, that I am asking, these examples are already marked as keras 3 on the website, so should I change this ops and let it be as it is? |
@divyashreepathihalli for this code Update: Fixed |
Data-Parallel Training with KerasNLP and tf.distribute This is an example using a dataset that shows 403: Forbidden. Giving the message "Access Denied.". Executed Notebook: https://colab.research.google.com/drive/1RbY321lKSodVP3Iy2vVq4kRlTUpfflMp#scrollTo=BfVweZvmOVpI |
@sitamgithub-MSIT kerasNLP would be a better place for this question. |
@sitamgithub-MSIT KerasNLP would be a better place for this question. Ok, I will raise an issue then in KerasNLP. Also here in this example CycleGAN, instance normalization is applied, and Keras does not have any support as of now. So, I replaced this with a batch normalization layer in Keras. Another thing is that the author proposed to run the model for only one epoch, as it takes nearly 7 to 8 minutes for one epoch. So I did that and made a few changes to the checkpoint file name so the weights could be stored. But the author here did the inference step with the same model architecture that ran over 90 epochs. As the model is not in.weights.h5 or.keras format, I cannot perform the inferencing. So I need your guidance on this. Also, here is the notebook I ran for reference. Executed Notebook: https://colab.research.google.com/drive/1NkXKivVipH2XrbbVlDJh0rgUogtr6yKZ?usp=sharing |
This PR changes the Monocular depth estimation example to keras 3.0 [TF-Only Example] as requested in [KerasCV-Fixit](keras-team/keras-cv#2211) Please find [gist](https://colab.sandbox.google.com/gist/chunduriv/994b36a97985e44d9573436b987993f9/tf_depth_estimation.ipynb).
The main goal is to stabilize KerasCV's integration with Keras 3. The list of outstanding items listed below needs to be adresses to make KerasCV feature complete with Keras 3 is listed below. Please feel free to take up anything here.
Here is the migration guide to move to Keras 3.
If you are taking up an example, do comment down below before you submit the PR.
High level process
python autogen.py add_example ../examples/vision/python_file_name
more contributing details here
import tensorflow as tf
- i.e it is a TF only example - please state that is the PR decriptiontensorflow_datasets
can be used with Keras 3 code, so if you encounter this, you can leave it as it is and it works.Update Keras IO examples - [Priority 1]
Generative
The text was updated successfully, but these errors were encountered: