Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with setuptools 72 #855

Closed
strujilloc opened this issue Jul 29, 2024 · 7 comments · Fixed by Shoobx/vcrpy#1 or #856
Closed

Fix compatibility with setuptools 72 #855

strujilloc opened this issue Jul 29, 2024 · 7 comments · Fixed by Shoobx/vcrpy#1 or #856

Comments

@strujilloc
Copy link

Due to Test command removal in setuptools, installation fails with version 72:

Collecting vcrpy
  Using cached vcrpy-6.0.1.tar.gz (84 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  error: subprocess-exited-with-error
  
  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [17 lines of output]
      Traceback (most recent call last):
        File "/private/var/folders/pb/0cllx_zx6vb88jht981qy96c0000gn/T/pip-build-env-c0ajc0p7/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 327, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=[])
        File "/private/var/folders/pb/0cllx_zx6vb88jht981qy96c0000gn/T/pip-build-env-c0ajc0p7/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 297, in _get_build_requires
          self.run_setup()
        File "/private/var/folders/pb/0cllx_zx6vb88jht981qy96c0000gn/T/pip-build-env-c0ajc0p7/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 497, in run_setup
          super().run_setup(setup_script=setup_script)
        File "/private/var/folders/pb/0cllx_zx6vb88jht981qy96c0000gn/T/pip-build-env-c0ajc0p7/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 313, in run_setup
          exec(code, locals())
        File "<string>", line 9, in <module>
      ModuleNotFoundError: No module named 'setuptools.command.test'
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.
@Toeplitz
Copy link

what's the most correct fix for this currently?

@agroszer
Copy link

Looks like GH actions just use exec pytest so is that piece of code still in use?

@DanieleIsoni
Copy link

I think this is a duplicate of #854

@agroszer
Copy link

I think this is a duplicate of #854

It is, but title is misleading.

@bitphage
Copy link

Fix via setting PIP_CONSTRAINTS pypa/setuptools#4519 (comment)

@omidkk
Copy link

omidkk commented Jul 29, 2024

@agroszer seems pre-commit and some tests failed after your PR.

CheckmkCI pushed a commit to Checkmk/checkmk that referenced this issue Jul 29, 2024
see kevin1024/vcrpy#855
and pypa/setuptools#4519

Change-Id: If5f8fb87549ed8628a06b08a3a9c03dfbdaf6633
CheckmkCI pushed a commit to Checkmk/checkmk that referenced this issue Jul 29, 2024
.. added missing pipenv command + newly locked Pipfile.lock
see kevin1024/vcrpy#855
and pypa/setuptools#4519

Change-Id: Ib0951b5f01ce89621390cb69e77241a8e5d4b854
CheckmkCI pushed a commit to Checkmk/checkmk that referenced this issue Jul 29, 2024
.. added missing pipenv command + newly locked Pipfile.lock
see kevin1024/vcrpy#855
and pypa/setuptools#4519

Change-Id: Ib0951b5f01ce89621390cb69e77241a8e5d4b854
@deronnax
Copy link

The problematic setuptools version has been yanked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants