Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Investigate parallel S5 fits rather than running each fit in parallel #315

Open
1 task done
taylorbell57 opened this issue May 9, 2022 · 0 comments
Open
1 task done
Assignees
Labels
enhancement New feature or request LC Fit

Comments

@taylorbell57
Copy link
Collaborator

Instrument

Light curve fitting (Stages 4-6)

What is your suggestion?

Currently in Stage 5 we have the ability to perform each fit in parallel. This is definitely the best way to parallelize the code for large fits (e.g. shared fits), but it might be faster to run multiple fits simultaneously rather than running one fit at a time with parallelization. This likely depends on how long it takes to evaluate the likelihood function, as I've heard before for emcee that parallelizing a single fit makes sense if your likelihood function takes ~0.1 seconds to evaluate or more; I have no idea if that same approximate timescale holds for something like dynesty though. If the overheads are too large to parallelize a single fit though, you can still speed up the overall Stage 5 time by running multiple channels' fits independently but in parallel (not as a shared fit, but spawn multiple workers to do multiple independent fits at the same time to use more of your CPU resources). This likely wouldn't be too hard to implement but we'd have to be careful with memory management and it may not end up providing significant improvements over the current parallelization technique. Perhaps we can wait until Yoni's profiling investigation through Issue #309 to determine if this is worth pursuing.

Error traceback output

No response

What operating system are you using?

No response

What version of Python are you running?

No response

What Python packages do you have installed?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request LC Fit
Projects
Status: To do
Development

No branches or pull requests

3 participants