Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Key4hep release #536

Closed
24 of 25 tasks
tmadlener opened this issue Oct 17, 2023 · 9 comments · Fixed by #538
Closed
24 of 25 tasks

New Key4hep release #536

tmadlener opened this issue Oct 17, 2023 · 9 comments · Fixed by #538

Comments

@tmadlener
Copy link
Contributor

tmadlener commented Oct 17, 2023

This issue is here to keep track of the PRs that should still be merged for a new Key4hep release as well as all of the tags that were made (and still need to be made)?

Please add PRs and tags that still need to be made to the list below.

PRs

Tags

  • podio v00-17-03
  • EDM4hep v00-10-02
  • k4FWCore v01-00pre17
  • k4MarlinWrapper v00-07
  • k4EDM4hep2LcioConv v00-07
  • CEPCSW 0.2.7
  • FCALClusterer 1.0.6
  • DD4hep 1.27
  • MarlinUtil v01-17-02
  • FCCAnalyses v0.8.0
  • FCCSW v1.0pre08
  • k4Gen (no changes since last tag)
  • k4geo
  • FCCDetectors v0.1pre10
  • k4SimDelphes v00-06
  • k4-project-template v0.4.0
  • k4RecCalorimter v0.1.0pre12
  • k4SimGeant4 v0.1.0pre13
  • ConformalTracking v01-12
  • LCIO v02-20-01
@tmadlener tmadlener added the enhancement New feature or request label Oct 17, 2023
@tmadlener tmadlener removed the enhancement New feature or request label Oct 17, 2023
@jmcarcell
Copy link
Contributor

I just saw you edited it @kjvbrt but I was going to ask for a timeline for the PRs, maybe next week we can start thinking about tagging?

@kjvbrt
Copy link
Contributor

kjvbrt commented Oct 24, 2023

Hi @jmcarcell. We plan to do all the tags tomorrow/Thursday.

@Zehvogel
Copy link
Contributor

@tmadlener can you also make a new MarlinUtil tag?

@jmcarcell
Copy link
Contributor

We should check this automatically, i.e. any packages that have commits after the tag that was used for the last release probably should be tagged. I'll have a look at this so we don't forget any

@andresailer
Copy link
Contributor

@tmadlener
Copy link
Contributor Author

I put all the open tags into the top level comment together with two currently open PRs that should still be included.

k4SimDelphes can in principle be used in its current version since there was only one PR that fixed some cmake warnings since then. Since k4SimDelphes is effectively a "leaf" in the dependency tree, this should be fairly straight forward to pick up in a small follow up release if necessary (i.e. if the PR takes too long).

For the following packages I am not entirely sure which PRs still need to go in:

  • k4FWCore
  • k4MarlinWrapper
  • k4geo

@kjvbrt can you make tags for the FCC[...] repositories once they are ready (or delegate to someone to make the tags) and tick the boxes in the top level comment? (If I just missed them, could you put the versions in?)

@jmcarcell I think you have the best overview over k4FWCore and know which PRs should still be in the tag and which ones we can leave open. Can you put the ones that need to go in, into the top level comment?

@andresailer I suppose you know best about k4geo, so could you do the same for that?

@tmadlener tmadlener linked a pull request Oct 30, 2023 that will close this issue
15 tasks
@andresailer
Copy link
Contributor

We have this issue with the MarlinWrapper key4hep/k4MarlinWrapper#158 that would cause occasional crashes, so would be nice to fix this before.

@andresailer
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants