From 31de4fcf84811ddd880bfdf6e4c408551c987c7a Mon Sep 17 00:00:00 2001 From: Nathan Fudenberg Date: Wed, 19 Jun 2024 10:06:22 -0400 Subject: [PATCH] tests: Update how kube2e tests report and update the glooctl check tests (#9634) * tests: Update how kube2e tests report and update the glooctl check tests * .github: job report naming * ok .github lets right these paths --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> --- .../composite-actions/kubernetes-e2e-tests/action.yaml | 2 +- changelog/v1.18.0-beta1/update-kube2e-tests.yaml | 6 ++++++ test/kubernetes/e2e/features/glooctl/check_suite.go | 7 +++++-- 3 files changed, 12 insertions(+), 3 deletions(-) create mode 100644 changelog/v1.18.0-beta1/update-kube2e-tests.yaml diff --git a/.github/workflows/composite-actions/kubernetes-e2e-tests/action.yaml b/.github/workflows/composite-actions/kubernetes-e2e-tests/action.yaml index f60198578af..681325eac05 100644 --- a/.github/workflows/composite-actions/kubernetes-e2e-tests/action.yaml +++ b/.github/workflows/composite-actions/kubernetes-e2e-tests/action.yaml @@ -37,5 +37,5 @@ runs: if: ${{ failure() }} uses: actions/upload-artifact@v4 with: - name: bug-report + name: bug-report-${{ inputs.cluster-name }} path: ./_test/bug_report/${{ inputs.cluster-name }} \ No newline at end of file diff --git a/changelog/v1.18.0-beta1/update-kube2e-tests.yaml b/changelog/v1.18.0-beta1/update-kube2e-tests.yaml new file mode 100644 index 00000000000..a2d4f4ecd05 --- /dev/null +++ b/changelog/v1.18.0-beta1/update-kube2e-tests.yaml @@ -0,0 +1,6 @@ +changelog: + - type: NON_USER_FACING + description: >- + Update how bugs report for gateway kube2e + Update all glooctl check tests to omit xds-metrics. This is a short term fix for nackdetector in solo-projects. + Add TODO to fix the underlying issue along with a link to a related envoy issue. \ No newline at end of file diff --git a/test/kubernetes/e2e/features/glooctl/check_suite.go b/test/kubernetes/e2e/features/glooctl/check_suite.go index ada55dc3673..f0eac6dadc6 100644 --- a/test/kubernetes/e2e/features/glooctl/check_suite.go +++ b/test/kubernetes/e2e/features/glooctl/check_suite.go @@ -21,6 +21,9 @@ type checkSuite struct { testInstallation *e2e.TestInstallation } +// NewChecksuite for glooctl check validation +// TODO(nfuden): Fix clusterloadassignment issues that forced xds-metrics to be excluded. +// Consider https://github.com/envoyproxy/envoy/issues/7529#issuecomment-1227724217 func NewCheckSuite(ctx context.Context, testInst *e2e.TestInstallation) suite.TestingSuite { return &checkSuite{ ctx: ctx, @@ -49,7 +52,7 @@ func (s *checkSuite) TestCheckExclude() { func (s *checkSuite) TestCheckReadOnly() { output, err := s.testInstallation.Actions.Glooctl().Check(s.ctx, - "-n", s.testInstallation.Metadata.InstallNamespace, "--read-only") + "-n", s.testInstallation.Metadata.InstallNamespace, "--read-only", "-x", "xds-metrics") s.NoError(err) for _, expectedOutput := range checkOutputByKey { @@ -69,6 +72,6 @@ func (s *checkSuite) TestCheckKubeContext() { // When passing the kube-context of the running cluster, `glooctl check` should succeed _, err = s.testInstallation.Actions.Glooctl().Check(s.ctx, - "-n", s.testInstallation.Metadata.InstallNamespace, "--kube-context", s.testInstallation.ClusterContext.KubeContext) + "-n", s.testInstallation.Metadata.InstallNamespace, "--kube-context", s.testInstallation.ClusterContext.KubeContext, "-x", "xds-metrics") s.NoError(err) }