Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate the kgateway chart into the repository #10423

Closed
Tracked by #10441
timflannagan opened this issue Jan 9, 2025 · 9 comments
Closed
Tracked by #10441

Integrate the kgateway chart into the repository #10423

timflannagan opened this issue Jan 9, 2025 · 9 comments
Assignees
Labels
Type: Enhancement New feature or request

Comments

@timflannagan
Copy link
Member

timflannagan commented Jan 9, 2025

Is your feature request related to a problem? Please describe.

We need a way for users to install the kubegateway project going forward. Historically, using helm has been the go-to option for most of the OSS Gloo users and we need to continue supporting that.

Describe the solution you'd like

Design a new helm chart from scratch. If needed, determine any migration gaps for existing GW API users.

DoD:

  • Any image component needed to pass the conformance suite
  • Functional helm chart can be deployed and passing CI checks
  • Defaults to the ghcr.io registry
  • Published helm chart artifacts via release.yaml workflow
  • CI is passing all checks

Out-of-scope:

  • Removing legacy chart. That can be done as a follow-up.

Describe alternatives you've considered

Avoid initial helm chart support. Users can install the kubegateway project via other options or tooling (e.g. kubectl apply static manifest, kustomize, etc.).

Additional Context

This is the tracker for the helm chart work that's outlined in the high-level #10363 epic.

@lgadban
Copy link
Contributor

lgadban commented Jan 10, 2025

This should also handle the publishing of the binary?

Related: what do we do w.r.t. envoy, see: https://github.com/orgs/k8sgateway/projects/3/views/6?pane=issue&itemId=93313462

@timflannagan
Copy link
Member Author

@lgadban s/binary/chart here right? I think that's fine to add to the scope of this issue. We can always split into separate issues if there's some open questions w.r.t where to publish the chart. I'll add a tasklist to this issue later today.

@lgadban
Copy link
Contributor

lgadban commented Jan 10, 2025

No I mean the binary/image of the controller that will be referenced within this helm chart.
IIUC as of now we do not publish that either

@timflannagan
Copy link
Member Author

WDYT about creating a tracker for all the release-related work then? Does the cloudbuilder bits release the binary as well? I think we could leverage goreleaser to build and publish the binary & image or massage everything together in GHAs.

@timflannagan
Copy link
Member Author

Just talking aloud, I think publishing the binary & image is more important than the helm chart work right now. Users can install the required CRDs & other misc. k8s resources using a static manifest.

@lgadban
Copy link
Contributor

lgadban commented Jan 10, 2025

I think that's fine, I had assumed this was intended to be the larger tracker that covered:

And initially https://github.com/orgs/k8sgateway/projects/3/views/6?pane=issue&itemId=91129014 but per slack discussion we will treat as a separate issue

@lgadban lgadban added this to the kgw OSS initial cut milestone Jan 12, 2025
@timflannagan timflannagan changed the title Add kubegateway helm charts Design & Develop Helm Chart for Control Plane Jan 13, 2025
@timflannagan
Copy link
Member Author

@lgadban Created #10441 to house the release-related work items you were mentioning. Updated this issue to be a sub-task under that new umbrella issue.

@lgadban lgadban moved this from Backlog to Planned in Kgateway Planning Jan 14, 2025
@lgadban lgadban moved this from Planned to In progress in Kgateway Planning Jan 21, 2025
@lgadban lgadban moved this from In progress to In review in Kgateway Planning Jan 23, 2025
@timflannagan
Copy link
Member Author

TODO: Follow-ups to the #10485 which integrated the new chart with CI. Either track those items here or close this out and track in the epic.

@timflannagan timflannagan changed the title Design & Develop Helm Chart for Control Plane Bootstrap initial kgateway helm chart Jan 24, 2025
@timflannagan timflannagan changed the title Bootstrap initial kgateway helm chart Integrate the kgateway chart into the repository Jan 24, 2025
@timflannagan
Copy link
Member Author

Closing - all the line items are now done. Additionally, the #10545 has merged which removed the legacy gloo chart.

@github-project-automation github-project-automation bot moved this from In review to Done in Kgateway Planning Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants