Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old gloo code #10444

Closed
lgadban opened this issue Jan 14, 2025 · 4 comments · Fixed by #10492, #10474, #10469, #10508 or #10514
Closed

remove old gloo code #10444

lgadban opened this issue Jan 14, 2025 · 4 comments · Fixed by #10492, #10474, #10469, #10508 or #10514
Assignees

Comments

@lgadban
Copy link
Contributor

lgadban commented Jan 14, 2025

As we continue bootstrapping the initial kgw standalone builds, we need to:

  1. properly define the go module
  2. remove legacy gloo edge/non k8s gateway api related code

In order to properly do 1, we will have to fix ALL internal imports.
Since we also need to take care of 2, it makes little sense to spend the time fixing the broken imports for dead code that is ultimately destined for the bit bucket.

We can accomplish this wholesale by:

  1. deleting the majority of the code not contained in the projects/gateway2 directory
  2. renaming the go mod
  3. fixing the leftover code imports
@lgadban lgadban moved this from Backlog to Planned in Kgateway Planning Jan 14, 2025
@lgadban lgadban added this to the kgw enterprise extensions part 1 milestone Jan 14, 2025
@lgadban lgadban moved this from Planned to In progress in Kgateway Planning Jan 17, 2025
@lgadban lgadban self-assigned this Jan 17, 2025
@lgadban lgadban modified the milestones: kgw enterprise extensions part 1, kgw OSS initial cut Jan 20, 2025
@lgadban
Copy link
Contributor Author

lgadban commented Jan 21, 2025

Follow ups:

  • Envoy Filter code
  • envoy API protos
  • envoy-gloo API protos
    • just importing from main now, but how does the release branch work?

global settings:

  • regex stuff / program size

@lgadban
Copy link
Contributor Author

lgadban commented Jan 21, 2025

track major functionality being removed:

  • helm unit tests

@lgadban
Copy link
Contributor Author

lgadban commented Jan 24, 2025

removing in-memory tests that live in test/e2e as they will need to rewritten entirely anyway to use the new framework
see: #10480 (comment)

@lgadban lgadban linked a pull request Jan 24, 2025 that will close this issue
@github-project-automation github-project-automation bot moved this from In progress to Done in Kgateway Planning Jan 24, 2025
@lgadban lgadban moved this from Done to In progress in Kgateway Planning Jan 24, 2025
@lgadban
Copy link
Contributor Author

lgadban commented Jan 24, 2025

more PRs to come, reopening

@lgadban lgadban reopened this Jan 24, 2025
@lgadban lgadban linked a pull request Jan 27, 2025 that will close this issue
@github-project-automation github-project-automation bot moved this from In progress to Done in Kgateway Planning Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment