Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Namespace in Docs incorrect #5

Open
idkjs opened this issue Oct 16, 2019 · 1 comment
Open

Project Namespace in Docs incorrect #5

idkjs opened this issue Oct 16, 2019 · 1 comment

Comments

@idkjs
Copy link

idkjs commented Oct 16, 2019

In docs you access this project with Apollo.

With current set up in stalled from npm, you would have to alias ReasonReactApollo.Project for it work.

module Apollo = ReasonReactApollo.Project;
let client = Apollo.createClient(~uri="http://http://localhost:50002", ());

[@react.component]
let make = () => {
  <Apollo.Provider client> <Component1 message="Hello! Click this text." /></Apollo.Provider>;
};

Looks promising. Happy to help work out the kinks in docs or whatever if you need the help. Keep up the good work, brother.

@kgoggin
Copy link
Owner

kgoggin commented Oct 21, 2019

Thanks for the catch! I think I'd originally planned to include those bindings inside the functor that gets included when you run the codegen. I think that still feels like a better solution, so that all of your Apollo stuff ends up in the same module? Or I could also move those to their own module so they're not lumped in with the codegen stuff. Let me think on it a bit...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants