Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Compute changes from a given revision/commit instead of using local changes #6

Open
jakub-bochenski opened this issue Dec 7, 2016 · 8 comments

Comments

@jakub-bochenski
Copy link

Should be useful for CI systems.

There is already an "Incremental Builds" option in Jenkins Maven Integration Plugin, but it doesn't work too well.

@khmarbaise
Copy link
Owner

What do you mean by it doesn't work too well?

@jakub-bochenski
Copy link
Author

For one it doesn't allow any control -- it always takes changes since last build, so you have to do a full build if there is a failure. Also you have to manually detect the above and force a full build in a roundabout way.

Most importantly though it requires the use of Maven Project type, which has a lot of bugs and incompatibilities

@howama
Copy link

howama commented Mar 3, 2017

This would be very useful if it automatically picked the revision to compute changes from.
My use case is doing a build after pulling changes made by other people. Ideally the incremental plugin would be able to work out if there are changes in the history since the last build of the module. (e.g. comparing artifact timestamps with those from the git history)

@famod
Copy link

famod commented May 22, 2018

I have hacked a solution for definining a revision and I am about to create a PR for this.

@khmarbaise For this I would like to introduce a system property incremental.startRev. WDYT?

@howama Nice idea! IMHO you should create a separate ticket for that as it goes well beyond the explicit definition of a revision by the user.

@jakub-bochenski
Copy link
Author

https://github.com/vackosar/gitflow-incremental-builder already handles this

@famod
Copy link

famod commented May 24, 2018

@jakub-bochenski Thanks for the pointer!
Unfortunately gitflow-incremental-builder needs an excessive amount of time to calculate the reactor in case a file is changed in the root project of a large project with many modules (with dependencies between those modules).
I will file an issue for that but as long as this isn't fixed gitflow-incremental-builder is not a viable alternative.

Edit: Issue reported: gitflow-incremental-builder/gitflow-incremental-builder#25

@jakub-bochenski
Copy link
Author

@famod please do file a report. I've heard about this problem from some of my colleagues but was never able to replicate it

@famod
Copy link

famod commented May 25, 2018

PR #16 sent, chose a shorter name for the property: imb.startRev (imb for incremental-module-builder).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants