Sweep: Write Unit Tests for AndroidHealthConnect inventory item

[kibagateaux]

Details

Ensure that:

1. there will not be any app crashes during function calls
2. we send crash and user analytics on all functions
3. generate test coverage for entire file
4. very descriptive test names and create jest categories with describe as much as possible

Checklist

• Create src/utils/inventory/android-health-connect.test.ts ✓ 9903b47 Edit

[sweep-ai]

Here's the PR! #3. See Sweep's process at dashboard.

⚡ Sweep Basic Tier: I'm using GPT-4. You have 5 GPT-4 tickets left for the month and 3 for the day. (tracking ID: d9a8f89dce)

For more GPT-4 tickets, visit our payment portal. For a one week free trial, try Sweep Pro (unlimited GPT-4 tickets).

---

Actions (click)

• ↻ Restart Sweep

Sandbox execution failed

The sandbox appears to be unavailable or down.

---

Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I think are relevant in decreasing order of relevance (click to expand). If some file is missing from here, you can mention the path in the ticket description.

jinni-mobile-app/src/utils/inventory/android-health-connect.ts

Lines 53 to 73 in dc017b1

	const checkEligibility = async (): Promise<boolean> => {
	if (Platform.OS !== 'android') return false;
	const status = await getSdkStatus();
	console.log('Inv:AndroidHealthConnect:checkEligibility: ', status);
	if (status !== SdkAvailabilityStatus.SDK_AVAILABLE) {
	console.log('Inv:AndroidHealthConnect:checkElig: NOT ELIIGBLE');
	// TODO link to Google play store link for download
	return false;
	}
	// @dev MUST always init first thing otherwise any SDK calls including getPermissions fails.
	// we always call checkEligibilty before anything else so all gucci.
	const isInitialized = await initialize();
	if (!isInitialized) throw Error('Unable to initialize Android Health');
	return true;
	};

jinni-mobile-app/src/types/GameMechanics.ts

Lines 107 to 161 in dc017b1

	export interface InventoryItem {
	// static metadata
	id: string;
	name: string;
	image: string;
	tags?: ItemTags[];
	attributes: StatsAttribute[];
	datasource: string;
	installLink?: string;
	//dynamic metadata
	status?: ItemStatus; // if undefined, call checkStatus() to get value and store to local object
	checkStatus: () => Promise<ItemStatus>;
	canEquip: () => Promise<boolean>;
	// gameplay actions
	// helper function passes in contextdual data, user input, react hook, etc. that we cant hardcode in equip()
	equip?: HoF;
	unequip?: HoF;
	// TODO refactor to object with ids as keys
	//
	abilities?: ItemAbility[]; // things user can do with the item
	// dont know if widget on item page will be same as WidgetConfig.
	// Might just be content and the id so only need list of ID strings here
	widgets?: ItemAbility[]; // things user can do with the item
	}
	export interface ItemAbility {
	id: string;
	name: string;
	symbol: string;
	description: string;
	isDoable?: boolean; // if undefined, call canDo() to get value and store to local object
	canDo: (status: ItemStatus) => Promise<boolean>; // checks if action can be done right now with current item status
	do: () => Promise<HoF>; // do sets up initial action e.g. querying item's api and returns a function for user to act after setup
	}
	// TODO I feel like this should all be rolled into InventoryItem
	export interface InventoryIntegration {
	item: InventoryItem;
	checkEligibility: () => Promise<boolean>;
	getPermissions: () => Promise<boolean>;
	initPermissions: () => Promise<boolean>;
	equip: (helper?: HoF) => Promise<boolean>;
	unequip: (helper?: HoF) => Promise<boolean>;
	}
	export type OAuthProviderIds = 'Spotify' | 'Github' | 'Coinbase' | 'Strava';
	export interface OAuthProvider {
	authorizationEndpoint: string;
	tokenEndpoint: string;
	revocationEndpoint?: string;
	clientId: string;
	scopes: string[];

jinni-mobile-app/src/utils/inventory/android-health-connect.ts

Lines 158 to 193 in dc017b1

	const item: InventoryItem = {
	id: ITEM_ID,
	name: 'Cyborg Repair Pack',
	datasource: ITEM_ID,
	tags: ['physical', 'exercise'],
	image: 'https://play-lh.googleusercontent.com/EbzDx68RZddtIMvs8H8MLcO-KOiBqEYJbi_kRjEdXved0p3KXr0nwUnLUgitZ5kQVWVZ=w480-h960-rw',
	installLink: 'https://play.google.com/store/apps/details?id=com.google.android.apps.healthdata',
	attributes: [
	{ ...DjinnStat, value: 5 },
	{ ...HealthStat, value: 10 },
	{ ...IntelligenceStat, value: 2 },
	],
	checkStatus,
	// must have app installed but not equipped yet
	canEquip: async () => (await checkEligibility()) === true && (await getPermissions()) === false,
	equip,
	unequip,
	// actions: [],
	};
	export default {
	item,
	checkEligibility,
	getPermissions,
	initPermissions,
	equip,
	unequip,
	} as InventoryIntegration;
	/**
	* @desc - Query Android health data from phone
	* @dev - Custom Item Function
	* @param
	* @returns HealthRecords[]
	*/

---

Step 2: ⌨️ Coding

• Create src/utils/inventory/android-health-connect.test.ts ✓ 9903b47 Edit

Create src/utils/inventory/android-health-connect.test.ts with contents:
• Create a new file `src/utils/inventory/android-health-connect.test.ts` for the unit tests.
• Import the necessary entities from `src/utils/inventory/android-health-connect.ts` and `src/types/GameMechanics.ts`. This includes the `InventoryItem` object and the functions `checkEligibility`, `getPermissions`, `initPermissions`, `equip`, and `unequip`.
• Write a `describe` block for each function and the `InventoryItem` object. Within each `describe` block, write multiple `it` or `test` blocks to test different scenarios.
• Use Jest's `mock` function to create mock functions and objects. This includes mocking the `Platform.OS` value to simulate different platforms and mocking the `console.log` function to test if the correct messages are logged.
• Use Jest's `expect` function to make assertions about the results of the function calls. This includes checking if the functions return the correct values and if they throw errors when expected.
• Generate a coverage report using Jest's built-in coverage tool to ensure full test coverage.

---

Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/android-health-connect-tests.

---

🎉 Latest improvements to Sweep:

• We just released a dashboard to track Sweep's progress on your issue in real-time, showing every stage of the process – from search to planning and coding.
• Sweep uses OpenAI's latest Assistant API to plan code changes and modify code! This is 3x faster and significantly more reliable as it allows Sweep to edit code and validate the changes in tight iterations, the same way as a human would.

---

💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request.
^{Join Our Discord}