Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest update broke patch model patcher + torch compile #151

Open
i-am-flashh opened this issue Dec 4, 2024 · 7 comments
Open

Latest update broke patch model patcher + torch compile #151

i-am-flashh opened this issue Dec 4, 2024 · 7 comments

Comments

@i-am-flashh
Copy link

I tried to regenerate the image with a previous workflow that was using (patch model patcher + torch compile) but the lora is not being applied. The image is being generated without lora.

When i remove the patch model patcher + torch compile nodes, the lora is applied.

It occasionally works , if i restart.

Note: I recently updated comfyui and all custom nodes,

@frankyifei
Copy link

Same

@15053285989
Copy link

same

@jepjoo
Copy link

jepjoo commented Dec 10, 2024

Same here, running the exact same workflow from 2 weeks ago and getting an image where LoRA isn't applied.

This is a really awesome feature, hoping it can get fixed.

@kijai
Copy link
Owner

kijai commented Dec 10, 2024

I have tracked this down to this commit, haven't figured out yet why it happens though: comfyanonymous/ComfyUI@79d5cea

@kijai
Copy link
Owner

kijai commented Dec 10, 2024

Okay so it works again, I'm not sure if this breaks something else now though, but basic workflow with LoRA and compile runs at the compiled speed with LoRA, and I can swap the LoRA just fine.

@akedia
Copy link

akedia commented Dec 18, 2024

Looks like the fix make the lora switch works, but the speed after switch is degraded back to no complie.

@frankyifei
Copy link

frankyifei commented Dec 18, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants