-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest update broke patch model patcher + torch compile #151
Comments
Same |
same |
Same here, running the exact same workflow from 2 weeks ago and getting an image where LoRA isn't applied. This is a really awesome feature, hoping it can get fixed. |
I have tracked this down to this commit, haven't figured out yet why it happens though: comfyanonymous/ComfyUI@79d5cea |
Okay so it works again, I'm not sure if this breaks something else now though, but basic workflow with LoRA and compile runs at the compiled speed with LoRA, and I can swap the LoRA just fine. |
Looks like the fix make the lora switch works, but the speed after switch is degraded back to no complie. |
It is worse than no compile, for me it is 10 times, and I have to add --low
vram, I wonder if it is loading model in ram instead or vram
akedia ***@***.***> 于 2024年12月18日周三 22:43写道:
… Looks like the fix make the lora switch works, but the speed after switch
is degraded back to no complie.
—
Reply to this email directly, view it on GitHub
<#151 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB52SO5TGBSMZHAI7JY2ISD2GFRGBAVCNFSM6AAAAABTAQ34M6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJRGE3DKNRSG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
I tried to regenerate the image with a previous workflow that was using (patch model patcher + torch compile) but the lora is not being applied. The image is being generated without lora.
When i remove the patch model patcher + torch compile nodes, the lora is applied.
It occasionally works , if i restart.
Note: I recently updated comfyui and all custom nodes,
The text was updated successfully, but these errors were encountered: