Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Escrow Approval Flow #60

Open
AndlerRL opened this issue Jan 22, 2025 · 20 comments
Open

Create Escrow Approval Flow #60

AndlerRL opened this issue Jan 22, 2025 · 20 comments
Assignees
Labels
difficulty: medium This issue requires a moderate to a little challenge effort on complexity feature New requested feature indexer indexer app related supabase supabase (database) service related TL TL Related webapp web app related

Comments

@AndlerRL
Copy link
Member

Context

The approval system manages the consensus mechanism for milestone completions and fund releases. It implements the multi-signature requirements of the smart contract while maintaining a user-friendly interface for all participants.

Approval Requirements:

  • Quorum calculation.
  • Signature validation.
  • State transition management.
  • Participant notification.

Acceptance Criteria:

  • Create /api/escrow/approve endpoint.
  • Implement multi-signature approval flow.
  • Add approval status tracking.
  • Create approval notification system.

Development Notes:

  • For escrow status, we need to track the events and state hence, we need to create tables to update such status. In SQL:
CREATE TABLE escrow_events (
    id UUID PRIMARY KEY DEFAULT uuid_generate_v4(),
    escrow_id UUID NOT NULL REFERENCES escrow_contracts(id),
    event_type TEXT NOT NULL,
    previous_state escrow_state,
    new_state escrow_state,
    transaction_hash TEXT,
    data JSONB,
    created_at TIMESTAMP WITH TIME ZONE DEFAULT CURRENT_TIMESTAMP
);
  • Check previous issues related to this, has key information/idea about how to manage the escrow off-chain tracking.
  • We may use the indexer to update the off-chain data and notify user through supabase subscriptions.

Blockers:

Related

@AndlerRL AndlerRL added difficulty: medium This issue requires a moderate to a little challenge effort on complexity feature New requested feature indexer indexer app related ODBoost Only Dust Boost Week Campaign ID supabase supabase (database) service related webapp web app related TL TL Related labels Jan 22, 2025
@Benjtalkshow
Copy link
Collaborator

I am a Full Stack Developer specializing in Next.js, TypeScript, Node.js, Cairo and Rust . With over 50 contributions across projects in the OnlyDust ecosystem, I’ve developed strong proficiency in delivering high-quality solutions and resolving complex issues within tight deadlines. My experience spans frontend, backend, smart contracts, and the optimization and maintenance of scalable codebases.

I can handle this task. Kindly assign.

@Michaelkingsdev
Copy link

May I try my hand at this?

@Ekene001
Copy link

Could I take on this issue? I’m a full-stack blockchain developer with over 3 years of experience working with Tailwind, React, TypeScript, and Solidity/Rust.

@Elite-tch
Copy link

Let me try this one!

@chiscookeke11
Copy link

I’d like to resolve this.

@Jagadeeshftw
Copy link
Collaborator

Proposal to Work on the Issue

I am eager to contribute to this issue and believe I am well-suited for the task, given my extensive experience in Cairo programming and building decentralized applications on StarkNet. My expertise spans across multiple domains crucial for this implementation:

  • Smart Contracts & Blockchain Development: Proven expertise in StarkNet, Stellar, and Rust, with hands-on experience in developing secure and efficient smart contracts, blockchain integrations, and high-performance backend systems.
  • Backend Engineering: Strong background in designing and managing scalable APIs, handling server-side operations, and ensuring robust backend performance for blockchain applications.
  • Frontend Development: Proficient in building intuitive and responsive frontend interfaces using React and Next.js, ensuring seamless interaction between users and blockchain-based applications.

Why Assign This to Me?

I have a track record of delivering high-quality solutions efficiently, with a deep understanding of smart contract security, decentralized architectures, and full-stack development. My ability to bridge frontend, backend, and blockchain components ensures a well-rounded, optimized solution.

Estimated Timeline

I anticipate delivering a fully functional solution within 2 days. Please let me know if I can proceed.

I am excited about the opportunity to contribute and look forward to collaborating!

Best regards,
Jagadeesh B

@1nonlypiece
Copy link

Application for Contribution

I am excited about the opportunity to contribute to this issue and am confident that my expertise aligns well with the requirements. With a strong background in Cairo programming and decentralized application development on StarkNet, I bring a well-rounded skill set to deliver an effective solution.

Relevant Expertise

  • Blockchain & Smart Contracts: Extensive experience with StarkNet, Stellar, and Rust, specializing in developing secure and optimized smart contracts, blockchain integrations, and high-performance backend infrastructure.
  • Backend Development: Well-versed in API design, server-side logic, and scalable system architecture, ensuring efficient and seamless backend performance.
  • Frontend Engineering: Skilled in crafting interactive and responsive UI components using React and Next.js, enhancing the user experience for blockchain-based platforms.

Why Consider My Application?

My proven track record of delivering high-quality, optimized solutions in blockchain and full-stack development sets me apart. I have a deep understanding of smart contract security, decentralized architectures, and the synergy between frontend, backend, and blockchain layers—ensuring a seamless and efficient implementation.

ETA

I expect to have a working solution ready within 48 hours. Please let me know if I can proceed with the implementation.

@qgatssdev
Copy link

Hey @AndlerRL, can i take this? I'm an experienced software engineer with over 4 years of experience and also an active only dust contributor. My ETA for this is 3 days.

@devJaja
Copy link

devJaja commented Jan 23, 2025

Let me handle this issue!
To implements the multi-signature requirements of the smart contract while maintaining a user-friendly interface for all participants. Which the approval system manages the consensus mechanism for milestone completions and fund releases.

@Supa-mega
Copy link

Could I take on this issue?

@greatest0fallt1me
Copy link

Proposal to Address the Issue

Hello! I’m thrilled at the opportunity to work on this issue and am confident that I can provide a solution that not only addresses the requirements but also adds value to the project. My experience in blockchain development and StarkNet ecosystems equips me to deliver a robust and efficient implementation.

My Unique Edge

  • Cairo Proficiency:
    Having worked extensively with Cairo, I excel at crafting gas-efficient, secure, and modular smart contracts, tailored for StarkNet’s scalability.

  • End-to-End Development:
    My expertise bridges the gap between smart contract engineering and full-stack application development, ensuring seamless blockchain integration.

  • Team Collaboration:
    I have a history of working closely with maintainers, adapting to project standards, and contributing to long-term maintainability.

Why This Matters to Me

I’m passionate about the innovative potential of StarkNet and the broader blockchain space. This issue aligns perfectly with my skills and interests, and I’m committed to delivering a solution that will enhance the project’s impact.

Immediate Action Plan

If assigned, I’ll initiate work immediately and aim to deliver the first draft within 36 hours. I’m flexible and open to feedback to ensure the solution aligns with project expectations.

Looking forward to your approval and the chance to contribute!

@Ved-viraj
Copy link

Hi, can I do this issue please? I'm new here, assign me this issue please. I am a full-stack developer and i can do this.

@caxtonacollins
Copy link

Is it okay if I take this?

@aidenwong812
Copy link

Can I handle this task?

@Jagadeeshftw
Copy link
Collaborator

Hi, I’d love to take on this issue! With my expertise in Cairo, StarkNet, and smart contract development, I can implement a clean and efficient solution.

Why Me?

  • Proven Blockchain Experience – Hands-on work with StarkNet, Solidity, and Rust, building secure and optimized smart contracts.
  • Full-Stack Capabilities – Strong in both backend (Rust, Node.js, Prisma) and frontend (React, Next.js) for seamless integration.
  • Efficient & Reliable – I deliver high-quality, production-ready solutions quickly while ensuring security and scalability.

Timeline

I estimate completing this within 1 day. Let me know if I can proceed!

Looking forward to contributing. 🚀

@Abrahamojobo
Copy link

Is it okay if I tackle this?

@Nomolos29
Copy link

I’m interested in this one.

@AndlerRL
Copy link
Member Author

AndlerRL commented Feb 7, 2025

@Jagadeeshftw -- you might need to sync with @davedumto since he is doing issue #63 in order for you to complete this task. The task needs to hear the escrow_satatus enum to update correctly the table hence the off-chain data. Though, I see that you can move in some parts but not the supabase connection with the table. Anything please let us know in the Telegram group! 🙌

@Jagadeeshftw
Copy link
Collaborator

@AndlerRL do I need to wait for the PR to be merged for issue 63 before I start this?

@AndlerRL AndlerRL removed the ODBoost Only Dust Boost Week Campaign ID label Feb 11, 2025
@AndlerRL
Copy link
Member Author

@AndlerRL do I need to wait for the PR to be merged for issue 63 before I start this?

@Jagadeeshftw To fully complete the task, yes. However you can move forward with the table creation of the rest of properties and work in the endpoints and connecting it with Trustless Work API. While you are on that, @davedumto can finish his task that it is at PR #150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium This issue requires a moderate to a little challenge effort on complexity feature New requested feature indexer indexer app related supabase supabase (database) service related TL TL Related webapp web app related
Projects
None yet
Development

No branches or pull requests