Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create TextArea component #636

Closed
PavelHolec opened this issue Jul 24, 2023 · 0 comments · Fixed by #724
Closed

Create TextArea component #636

PavelHolec opened this issue Jul 24, 2023 · 0 comments · Fixed by #724
Assignees
@PavelHolec
Labels
feature Orbit component related changes
Milestone
2023Q4

Comments

@PavelHolec
Copy link
Collaborator

PavelHolec commented Jul 24, 2023 •
edited
Loading

Should reuse most of existing TextField + InputField code. Modifiers for a call site should also be the same (except for TextArea-specific configuration, such as number of lines etc).

Both components should have interchangeable API.

The code is already mostly prepared in Kiwi.com project

image
@PavelHolec PavelHolec added the feature Orbit component related changes label Jul 24, 2023
@PavelHolec PavelHolec added this to the 2023Q3 milestone Jul 24, 2023
@PavelHolec PavelHolec self-assigned this Aug 15, 2023
@PavelHolec PavelHolec modified the milestones: 2023Q3, 2023Q4 Oct 16, 2023
@PavelHolec PavelHolec linked a pull request Nov 23, 2023 that will close this issue
Create Textarea component #724
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PavelHolec PavelHolec

Labels
feature Orbit component related changes
Projects
None yet
Milestone
2023Q4
Development

Successfully merging a pull request may close this issue.

Create Textarea component kiwicom/orbit-swiftui
1 participant
@PavelHolec