Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the user switches themes, popovers do not adapt for current page #696

Open
Jaifroid opened this issue Feb 25, 2025 · 1 comment
Open
Labels
bug/non-critical upstream Should be worked on in kiwix-js user interface UI issues
Milestone

Comments

@Jaifroid
Copy link
Member

When the user switches to dark or light themes, popovers do not get re-styled until the user loads a new article (or re-loads the current article).

@Jaifroid Jaifroid added bug/non-critical upstream Should be worked on in kiwix-js user interface UI issues labels Feb 25, 2025
@Jaifroid Jaifroid added this to the Release 3.6.0 milestone Feb 25, 2025
@Jaifroid
Copy link
Member Author

This will affect KJS upstream as well. The problem is that different popover styling is loaded on page load. It could be solved by reloading the current article, but that would be a clunky experience. It would be better to remove the current styles and load the new ones. Or else find a way for the CSS of the popovers to respond to the theme of the page automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/non-critical upstream Should be worked on in kiwix-js user interface UI issues
Projects
None yet
Development

No branches or pull requests

1 participant