-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary space below search bar when screen is narrow #1214
Comments
@Jaifroid i would like to fix this issue, please assign this to me |
@Sky-De Please take a look at https://github.com/kiwix/kiwix-js/blob/main/CONTRIBUTING.md (read it all the way through), set up your development environment, and make sure you're happy with the process here. If all is well, please come back here outlining your suggestion of how to complete this issue so that I can assign you. |
@Jaifroid i will do that tomorrow and I'll inform you, thanks for quick response |
can you merge PR @Jaifroid |
Have this issue been solved already? |
@amr-salahuddin Yes, @Aditya0049 already has a PR: |
I want to work on this @Jaifroid ! |
OK. Please check out the previous PR and what was wrong with it. Be sure to follow instructions in CONTRIBUTING.md so you know how to set up your development environment and test properly. |
This issue has been sitting for a while, so I thought maybe I could help finally fix this. I read the convo at #1216 and the follow up there makes simple sense. Extending on that, I noticed a couple of other issues with the For one, the "random article" button has its font-size reduced at smaller widths (768px) which in-turn reduces its height, making it look awkward next to the other elements. Second, the "random article" button behaves weirdly at smaller sizes due to the constant padding around it. On smaller mobile devices, it even starts to clip out of the screen - even though there is more than sufficient spacing to its left. I think a better approach might be to make the spacing around the elements even. And at larger screen widths, we can expand the random article button to potentially show a label. I created the following mockups: Now that Container Queries are Baseline Newly Available, we can potentially use them to implement a more consistent logic for the If its available, can you assign me this issue, so that I can start working on it? |
Although this is not noticeable on desktop, on narrow form factors, the excessive amount of space below the search bar is extremely noticeable. While the ultimate solution to this is #523, in the meantime, it would be a quick fix to remove the space now. See screenshot.
The text was updated successfully, but these errors were encountered: