Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert jQuery .click(), .focus(), .attr() and other homologous functions to their native equivalents #919

Closed
Jaifroid opened this issue Nov 14, 2022 · 6 comments · Fixed by #925
Assignees
Labels
cleanup remove-jquery Issues or PRs involving removal of jQuery
Milestone

Comments

@Jaifroid
Copy link
Member

Sub-issue of #367.

@Jaifroid Jaifroid added cleanup remove-jquery Issues or PRs involving removal of jQuery labels Nov 14, 2022
@Jaifroid Jaifroid added this to the v3.7 milestone Nov 14, 2022
@dheerajdlalwani
Copy link
Contributor

dheerajdlalwani commented Nov 16, 2022

This seems like a nice, low hanging fruit to start contributing. I'd like to take this one up, @Jaifroid
Can you assign it to me?

@Jaifroid
Copy link
Member Author

@dheerajdlalwani Thank you for the offer. Please note that for these issues about jQuery, it's mandatory to test on IE11, or in IE11 mode in Edge Chromium. This is because it is old browsers that are likely to be affected by removal of jQuery. Please also read the CONTRIBUTING guidelines, and confirm you're happy to follow them and also to test on IE11 or IE Mode. This complicates things a bit. If you are running Windows 11, let me know and I can tell you how to open real IE11 very easily even though it has been "removed" from the OS. If you run Linux and don't have access to a Windows machine/OS, probably this issue might not be the best one for you.

@dheerajdlalwani
Copy link
Contributor

Oh yes! I read the CONTRIBUTING guidelines and I am more than happy to do the required testing for IE 11.
And also, yes I am running Windows 11.

@Jaifroid
Copy link
Member Author

Great thanks. The easiest way to open IE11 in Win11 is to open Control Panel (win key -> type "control"), click on "Network and Internet", then "Internet Options". A dialogue box like below should open up. Then click on the question mark circled in red. IE11 should open up. You can open Dev Tools as usual with F12 key.

image

@Jaifroid
Copy link
Member Author

You should find https://youmightnotneedjquery.com/ helpful in finding alternatives and ensuring they are valid for at least IE11+. There's another resource listed towards top of #367 that allows you to view jQuery's own source code for its functions. That resource is archived on the Internet Archive.

@Jaifroid
Copy link
Member Author

@dheerajdlalwani If you find cases that are intertwined, feel free to include some elements of #918 in any PR fixing this issue. But I think you may find that some of the changes required in #918 are a bit more complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup remove-jquery Issues or PRs involving removal of jQuery
Projects
None yet
2 participants