Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiwix serve welcome page filter by content type / Flavour #545

Open
kelson42 opened this issue Apr 11, 2021 · 4 comments
Open

Kiwix serve welcome page filter by content type / Flavour #545

kelson42 opened this issue Apr 11, 2021 · 4 comments

Comments

@kelson42
Copy link
Collaborator

kelson42 commented Apr 11, 2021

Should propose this:

  • with videos
  • picture only
  • text only

Tiles should display the flavour as well to avoid confusion

This superseeds somehow #421

@kelson42 kelson42 transferred this issue from kiwix/kiwix-tools Jun 6, 2021
@stale
Copy link

stale bot commented Aug 18, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Aug 18, 2021
@stale stale bot removed the stale label Aug 20, 2021
@kelson42 kelson42 changed the title Kiwix serve welcome page filter by content type Kiwix serve welcome page filter by content type / Flavour Aug 21, 2021
@kelson42 kelson42 added this to the 10.2.0 milestone Dec 7, 2021
@stale
Copy link

stale bot commented Jul 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@rgaudin
Copy link
Member

rgaudin commented Jan 24, 2023

I understand this should be implemented using a static in-reader list of the flavour ; right?

{
    "mini": "???",
    "nopic": "text only",
    "maxi": "picture only",
    "": "with videos",
}

Provided wording is incomplete and misleading IMO (“with videos”).

I can't seem to find a reference to those (I don't think the original super-long ticket introducing flavour is appropriate). We should definitely add that to the overview Wiki, especially since this will need to be duplicated in several readers (and localized)

@stale stale bot removed the stale label Jan 24, 2023
@kelson42
Copy link
Collaborator Author

At this stage, we agree, we want this simple additional filter feature implemented at OPDS entries level. UI stuff will be considered later within #421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants