Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close event does not seem to have any argumments #32

Closed
pateketu opened this issue Jan 3, 2017 · 3 comments · May be fixed by #37
Closed

close event does not seem to have any argumments #32

pateketu opened this issue Jan 3, 2017 · 3 comments · May be fixed by #37

Comments

@pateketu
Copy link

pateketu commented Jan 3, 2017

Hello,

I am trying to capture the close event and prevent window from closing based on some validation rule, following plunker shows http://plnkr.co/edit/EacLulnJbMqUffufjmgn?p=preview that the close event has got the "event" argument but latest version of kWindow that I have does not seem to have any arguments in close event?

Thanks
Ketul

@kjartanvalur
Copy link
Owner

This is a limitation to the close event because that is a kendo event. But I suggest you do your validation in the dialog where you have a save and cancel button events. But the limitation then is when the user clickes the x button in the top-right corner... But there are ways to deal with that e.g. rootscope dirty flag.

@pateketu
Copy link
Author

I ended up doing validation on the save button in the dialog, did not need to trigger validation on cancel or X button!

@kjartanvalur
Copy link
Owner

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants