Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add TestLessThanOrEqual hint #121

Open
Tracked by #90
zmalatrax opened this issue Aug 6, 2024 · 3 comments · May be fixed by #133
Open
Tracked by #90

feat: add TestLessThanOrEqual hint #121

zmalatrax opened this issue Aug 6, 2024 · 3 comments · May be fixed by #133
Assignees
@LazarusAA
Labels
good first issue Good for newcomers

Comments

@zmalatrax
Copy link
Collaborator

zmalatrax commented Aug 6, 2024 •
edited
Loading

Estimated time: 0.5d
Lifespan: 1d

  • Implement the TestLessThanOrEqual hint.
  • Add unit tests, testing the parsing and the logic of the hint.
  • Add a Cairo program using the hint, used as an integration test .

How-to implement a hint on the Cairo VM TS available here

Rust implementation reference
@zmalatrax zmalatrax mentioned this issue Aug 6, 2024
Open
@zmalatrax zmalatrax moved this to 🔖 Ready in Cairo VM ts Aug 6, 2024
@zmalatrax zmalatrax added the good first issue Good for newcomers label Aug 6, 2024
@LazarusAA
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hi, team
I'm a software engineer with experience in Solidity and Typescript, I want to contribute and complete the issue to further expand my abilities and familiarize with Cairo.

How I plan on tackling this issue

First, I will take an overview look at the repository and understand how implementing a hint works. Then I will follow the steps given in the issue and make sure my deliverable passes all acceptance criteria.

@zmalatrax
Copy link
Collaborator Author

Sure, assigned

@zmalatrax zmalatrax moved this from 🔖 Ready to 🏗️ In progress in Cairo VM ts Aug 6, 2024
@Rana718
Copy link

Rana718 commented Aug 28, 2024

I would like to take this up!

@zmalatrax zmalatrax linked a pull request Aug 28, 2024 that will close this issue
feat: add TestLessThanOrEqual hint #133
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LazarusAA LazarusAA

Labels
good first issue Good for newcomers
Projects
Cairo VM ts
Status: 🏗️ In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add TestLessThanOrEqual hint LazarusAA/cairo-vm-ts
3 participants
@zmalatrax @LazarusAA @Rana718