Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use scarb macro to generate const powers #841

Open
2 tasks
enitrat opened this issue Aug 21, 2024 · 4 comments · May be fixed by #865
Open
2 tasks

feat: use scarb macro to generate const powers #841

enitrat opened this issue Aug 21, 2024 · 4 comments · May be fixed by #865
Assignees
@juankohler
Labels
enhancement New feature or request good first issue Good for newcomers timebox-1hr 1 Hour exploration - tinkering

Comments

@enitrat
Copy link
Collaborator

enitrat commented Aug 21, 2024 •
edited
Loading

Feature Request

Describe the Feature Request

Instead of pre-computing powers of two and copy-paste the values in Cairo, use a macro to generate the values at compile time.

Describe Preferred Solution

Alexandria has a macros package that has exactly this. keep-starknet-strange/alexandria#324 (review)

Related Code

Additional Context

If the feature request is approved, would you be willing to submit a PR?
(Help can be provided if you need assistance submitting a PR)

  • Yes
  • No
@enitrat enitrat added the enhancement New feature or request label Aug 21, 2024
@enitrat enitrat added good first issue Good for newcomers timebox-1hr 1 Hour exploration - tinkering labels Aug 22, 2024
@juankohler
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I have over 7 years of experience in backend development, primarily using Go. While my expertise is in building robust backend systems, I’m currently learning Cairo in Dojo Coding and am eager to apply my skills to contribute effectively to projects using this language.

@ClementWalter
Copy link
Member

@juankohler what's the status of this?

@enitrat
Copy link
Collaborator Author

enitrat commented Sep 10, 2024

@ClementWalter the Language Server has some issues with procedural macros (they're undetected so considered as errors) - as such I don't want to merge it yet, I reported the issue and proposed them to simply mute diagnostics for macros.

@enitrat enitrat linked a pull request Sep 10, 2024 that will close this issue
Draft
9 tasks
@maxslimb
Copy link

@enitrat is this issue completed ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juankohler juankohler

Labels
enhancement New feature or request good first issue Good for newcomers timebox-1hr 1 Hour exploration - tinkering
Projects
Kakarot's Project Management
Status: 🆕 Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use scarb macro to generate const powers juankohler/kakarot-ssj
4 participants
@ClementWalter @juankohler @maxslimb @enitrat