Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Not reproducible] AmesHousing::make_ames doesn't show entire data cleaning process #65

Open
e-linc opened this issue Feb 8, 2023 · 1 comment

Comments

@e-linc
Copy link

e-linc commented Feb 8, 2023

The yellow note in Section 1.4 when introducing the AmesHousing dataset says an entire data cleaning process to transform the raw Ames housing data could be seen by typing AmesHousing::make_ames in the R console.

However, it only shows the definition of a wrapper for a function called process_ames(). I am not sure this qualifies as the "entire data cleaning process", or am I missing anything?

@guidothekp
Copy link

make_ames is a function. So the correct invocation needs to be AmesHousing::make_ames(). However, as the bug filer has mentioned, the "entire data cleaning process" is not visible. What we get back is a tibble that is the final result.

So there are two bugs, if I understand correctly.

  1. The yellow note needs to read "You can see the entire data cleaning process to transform the raw Ames housing data (AmesHousing::ames_raw()) to the final clean data (AmesHousing::make_ames()) that we will use in machine learning algorithms throughout this book by typing AmesHousing::make_ames() into the R console. "
  2. The statement "entire data cleaning process" needs to be clarified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants