Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove httplib2 #346

Open
esmail opened this issue Apr 10, 2017 · 0 comments
Open

Remove httplib2 #346

esmail opened this issue Apr 10, 2017 · 0 comments
Assignees
Labels
low priority To be done later

Comments

@esmail
Copy link

esmail commented Apr 10, 2017

Update: I don't see httplib2 anywhere in KC's code except for requirements files (checked in https://github.com/kobotoolbox/kobocat/tree/kobokitten-py3-django2-new-settings) —jnm

Original description:

As identified in #158, the currently-installed version of httplib2 results in certificate verification errors such as the following on apparently-acceptable sites like www.openfn.org:

SSLHandshakeError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:590)

Without upgrading httplib2 or resorting to using disable_ssl_certificate_validation=True, we can easily substitute in the already-installed requests library, which is not subject to these verification errors, and drop a dependency in the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority To be done later
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants